Add google oauth2 support #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work. thanks :) |
|
No problem, I'll try to add other providers in the near future. There is also some duplication in the oauth2.rb protocol code now, I'll fix that as well. |
|
One small question. Am I right to thing that I can switch from omniauth-google gem to omniauth-google-oauth2 ? |
|
@almaron I'm not so sure, but I would appreciate you if you try it and report about it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
I cleaned up my code and manage to make it work with oauth2 version 0.4.1 I'm having trouble making facebook work with 0.5.1 just like you said, I'll dig into it later on.
I have built a small rails app to test facebook and google auth. I'll put it on another repo and post a link. I used the tests for facebook to build those for google but if it needs more testing love, let me know.
Cheers