Solves problems between MongoMapper and brute_force_protection. #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A workaround is needed since mongomapper method is increment too and it cannot be aliased there.
|
Thanks - would be nice to have a test for this as well. |
NoamB
added a commit
that referenced
this pull request
Jan 24, 2012
Solves problems between MongoMapper and brute_force_protection.
|
Main problem testing the default value with mongo_mapper is that at the moment, default values are not applied until saving without monkey-patching. Not a clue how to work that out until they fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorcery was using the inc method that was working. It got replaced by self.class.increment for mongo_mapper (increment instance method implementation in MongoMapper). Though, maybe changing the name of sorcery's method would be best.
Furthermore, it gives the count_attribute in said submodule a default value of 0, since it fails otherwise.