Change model_class_name behaviour #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use classify instead of capitalize to make the behaviour of the generator more similar to Rails model generator. - Use underscore instead of downcase for consistency with the previous change
NoamB
added a commit
that referenced
this pull request
Mar 30, 2012
Change model_class_name behaviour
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more similar to Rails model generator.
I think it's a fair change. This morning I run:
rails g sorcery:install --model AdminOrganizationAnd the output really surprised me.
Thank you for working on this great engine! I'm actually using it on all my brand-new projects.