Move defining fields to adapters #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently in every single submodule that requires additional fields in model, we've got a conditional block for each ORM. To reduce code duplication, a `define_field` method was added to each of ORM adapters. Now we can run it no matter what ORM is used, and adapter will handle it.
Just like in case of fields, defining callbacks should be done the same way for all adapters. This version includes basic definition that handles all currently used in Sorcery cases
|
Looks good! I would rename |
|
Good point! I still need to fix some issues with DataMapper, I hope to finish it tomorrow. |
As pointed by @kirs, these names are quite general. To avoid potential problems they were renamed to define_sorcery_field and define_sorcery_callback
arnvald
added a commit
that referenced
this pull request
Jul 4, 2014
Move defining fields to adapters
|
Done! It took me a while, but it looks better now. I'm already working on decoupling the rest of code from ORMs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in every single submodule that requires additional fields in model,
we've got a conditional block for each ORM. To reduce code duplication,
a
define_fieldmethod was added to each of ORM adapters. Now we can run it nomatter what ORM is used, and adapter will handle it.
This is the first step to extracting adapters. Next one will be to move defining callbacks to adapters.
cc @kirs
Update
Ok, I've already moved defining callbacks, too, and I've added it to this PR.