Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advertising timeout #167

Merged
merged 12 commits into from
Dec 6, 2024
Merged

Advertising timeout #167

merged 12 commits into from
Dec 6, 2024

Conversation

philips77
Copy link
Member

This PR fixes some issues in the advertiser:

  1. Timeouts set should be respected, and the advertising flow should get closed on completion
  2. "Stop" button now correctly cancels the job and stops advertising

Some other fixes.

In general, I recommend using version/2 branch.

@philips77 philips77 merged commit a55ba59 into main Dec 6, 2024
1 check passed
@philips77 philips77 deleted the bugfix/162 branch December 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant