Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI and test with JUnit #5

Merged
merged 5 commits into from
May 4, 2024
Merged

Conversation

kevinthegreat1
Copy link
Contributor

Added CI and test with JUnit.
Also updated from gradle 7.4 to 8.7. (All the wrapper and gradlew changes are done automatically with ./gradlew wrapper --gradle-version 8.7.)
See test here.

@kevinthegreat1
Copy link
Contributor Author

GitHub doesn't like how I moved the test file, but you can compare the deleted TestMain with the new one to see the diff. I just replaced everything with assertions. Hope this helps.

@kevinthegreat1
Copy link
Contributor Author

Closes #4

@nea89o
Copy link
Member

nea89o commented May 3, 2024

Rebased this so i can have the gradle wrapper validation action run on this. I am not too sure about those tests. Some of those seem very fragile keeping in mind future updates (for example max fairy souls will certainly change at some point). Maybe this can be helped by pinning the repo commit? I also think those tests should be split up into multiple functions.

@kevinthegreat1
Copy link
Contributor Author

Done

@nea89o nea89o merged commit 533eae7 into NotEnoughUpdates:master May 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants