Merge pull request EduardoPires#165 from EduardoPires/CodeImprovements

Sonarqube improvements

src/Equinox.Application/EventSourcedNormalizers/CustomerHistory.cs

@@ -6,7 +6,7 @@
 
 namespace Equinox.Application.EventSourcedNormalizers
 {
-    public class CustomerHistory
+    public static class CustomerHistory
     {
         public static IList<CustomerHistoryData> HistoryData { get; set; }
 
@@ -67,6 +67,11 @@ private static void CustomerHistoryDeserializer(IEnumerable<StoredEvent> storedE
                         historyData.Action = "Removed";
                         historyData.Who = e.User;
                         break;
+                    default:
+                        historyData.Action = "Unrecognized";
+                        historyData.Who = e.User ?? "Anonymous";
+                        break;
+
                 }
                 HistoryData.Add(historyData);
             }

src/Equinox.Domain.Core/Models/ValueObject.cs

@@ -5,7 +5,7 @@ public abstract class ValueObject<T> where T : ValueObject<T>
         public override bool Equals(object obj)
         {
             var valueObject = obj as T;
-            return !ReferenceEquals(valueObject, null) && EqualsCore(valueObject);
+            return EqualsCore(valueObject);
         }
 
         protected abstract bool EqualsCore(T other);
@@ -19,10 +19,10 @@ public override int GetHashCode()
 
         public static bool operator ==(ValueObject<T> a, ValueObject<T> b)
         {
-            if (ReferenceEquals(a, null) && ReferenceEquals(b, null))
+            if (a is null && b is null)
                 return true;
 
-            if (ReferenceEquals(a, null) || ReferenceEquals(b, null))
+            if (a is null || b is null)
                 return false;
 
             return a.Equals(b);

src/Equinox.Infra.CrossCutting.IoC/NativeInjectorBootStrapper.cs

@@ -16,7 +16,7 @@
 
 namespace Equinox.Infra.CrossCutting.IoC
 {
-    public class NativeInjectorBootStrapper
+    public static class NativeInjectorBootStrapper
     {
         public static void RegisterServices(IServiceCollection services)
         {

src/Equinox.Infra.Data/Context/EquinoxContext.cs

@@ -46,7 +46,7 @@ public async Task<bool> Commit()
             // side effects from the domain event handlers which are using the same DbContext with "InstancePerLifetimeScope" or "scoped" lifetime
             // B) Right AFTER committing data (EF SaveChanges) into the DB will make multiple transactions. 
             // You will need to handle eventual consistency and compensatory actions in case of failures in any of the Handlers. 
-            await _mediatorHandler.PublishDomainEvents(this);
+            await _mediatorHandler.PublishDomainEvents(this).ConfigureAwait(false);
 
             // After executing this line all the changes (from the Command Handler and Domain Event Handlers) 
             // performed through the DbContext will be committed

src/Equinox.Services.Api/Configurations/SwaggerConfig.cs

@@ -19,7 +19,7 @@ public static void AddSwaggerConfiguration(this IServiceCollection services)
                     Title = "Equinox Project",
                     Description = "Equinox API Swagger surface",
                     Contact = new OpenApiContact { Name = "Eduardo Pires", Email = "[email protected]", Url = new Uri("http://www.eduardopires.net.br") },
-                    License = new OpenApiLicense() { Name = "MIT", Url = new Uri("https://github.com/EduardoPires/EquinoxProject/blob/master/LICENSE") }
+                    License = new OpenApiLicense { Name = "MIT", Url = new Uri("https://github.com/EduardoPires/EquinoxProject/blob/master/LICENSE") }
                 });
 
                 s.AddSecurityDefinition("Bearer", new OpenApiSecurityScheme

src/Equinox.Services.Api/Controllers/ApiController.cs

@@ -9,7 +9,7 @@ namespace Equinox.Services.Api.Controllers
     [ApiController]
     public abstract class ApiController : ControllerBase
     {
-        public ICollection<string> Errors = new List<string>();
+        private readonly ICollection<string> _errors = new List<string>();
 
         protected ActionResult CustomResponse(object result = null)
         {
@@ -20,7 +20,7 @@ protected ActionResult CustomResponse(object result = null)
 
             return BadRequest(new ValidationProblemDetails(new Dictionary<string, string[]>
             {
-                { "Messages", Errors.ToArray() }
+                { "Messages", _errors.ToArray() }
             }));
         }
 
@@ -47,17 +47,17 @@ protected ActionResult CustomResponse(ValidationResult validationResult)
 
         protected bool IsOperationValid()
         {
-            return !Errors.Any();
+            return !_errors.Any();
         }
 
         protected void AddError(string erro)
         {
-            Errors.Add(erro);
+            _errors.Add(erro);
         }
 
         protected void ClearErrors()
         {
-            Errors.Clear();
+            _errors.Clear();
         }
     }
 }

src/Equinox.Services.Api/Program.cs

@@ -3,7 +3,7 @@
 
 namespace Equinox.Services.API
 {
-    public class Program
+    public static class Program
     {
         public static void Main(string[] args)
         {

src/Equinox.Services.Api/Startup.cs

@@ -58,7 +58,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddDependencyInjectionConfiguration();
         }
 
-        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
+        public static void Configure(IApplicationBuilder app, IWebHostEnvironment env)
         {
             if (env.IsDevelopment())
             {

src/Equinox.UI.Web/Areas/Identity/IdentityHostingStartup.cs

@@ -7,8 +7,7 @@ public class IdentityHostingStartup : IHostingStartup
     {
         public void Configure(IWebHostBuilder builder)
         {
-            builder.ConfigureServices((context, services) => {
-            });
+            builder.ConfigureServices((context, services) => {});
         }
     }
 }

src/Equinox.UI.Web/Areas/Identity/Pages/Account/Register.cshtml.cs

@@ -88,7 +88,7 @@ public async Task<IActionResult> OnPostAsync(string returnUrl = null)
                     var callbackUrl = Url.Page(
                         "/Account/ConfirmEmail",
                         pageHandler: null,
-                        values: new { area = "Identity", userId = user.Id, code = code },
+                        values: new { area = "Identity", userId = user.Id, code },
                         protocol: Request.Scheme);
 
                     await _emailSender.SendEmailAsync(Input.Email, "Confirm your email",

src/Equinox.UI.Web/Controllers/BaseController.cs

@@ -7,7 +7,7 @@ namespace Equinox.UI.Web.Controllers
 {
     public class BaseController : Controller
     {
-        public ICollection<string> Errors = new List<string>();
+        private readonly ICollection<string> _errors = new List<string>();
 
         protected bool ResponseHasErrors(ValidationResult result)
         {
@@ -23,12 +23,12 @@ protected bool ResponseHasErrors(ValidationResult result)
 
         protected void AddProcessError(string erro)
         {
-            Errors.Add(erro);
+            _errors.Add(erro);
         }
 
         public bool IsValidOperation()
         {
-            return !Errors.Any();
+            return !_errors.Any();
         }
     }
 }

src/Equinox.UI.Web/Program.cs

@@ -3,7 +3,7 @@
 
 namespace Equinox.UI.Web
 {
-    public class Program
+    public static class Program
     {
         public static void Main(string[] args)
         {

src/Equinox.UI.Web/Startup.cs

@@ -64,7 +64,7 @@ public void ConfigureServices(IServiceCollection services)
             services.AddDependencyInjectionConfiguration();
         }
 
-        public void Configure(IApplicationBuilder app, IWebHostEnvironment env)
+        public static void Configure(IApplicationBuilder app, IWebHostEnvironment env)
         {
             if (env.IsDevelopment())
             {