Skip to content

Commit

Permalink
Minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ly0va committed Nov 1, 2020
1 parent 950f38b commit a306d95
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
run: |
rustup update stable
cargo sqlx --version || cargo install --version=0.1.0-beta.1 sqlx-cli
docker pull matterlabs/ci-integration-test:latest
docker pull matterlabs/ci-integration-test:zk-latest
- name: zk
run: zk
Expand Down
2 changes: 1 addition & 1 deletion bin/zk
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ if [ -z "$1" ]; then
yarn && yarn build
else
# can't start this with yarn since it has quirks with `--` as an argument
node $ZKSYNC_HOME/infrastructure/zk/build/index.js -- "$@"
node $ZKSYNC_HOME/infrastructure/zk/build/index.js "$@"
fi
1 change: 1 addition & 0 deletions docker/exit-tool/exit-tool-entry.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ then
exit 1
fi

zk
zk run plonk-setup
zk run verify-keys unpack
zk db wait
Expand Down
3 changes: 2 additions & 1 deletion docker/integration-test/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ WORKDIR /usr/src/zksync
RUN apt-get update; apt-get install -y make bash git postgresql openssl libssl-dev gcc g++ curl libpq-dev pkg-config software-properties-common jq

# Install node and yarn
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -
RUN curl -sL https://deb.nodesource.com/setup_14.x | bash -
RUN apt-get install -y nodejs
RUN npm install -g yarn

Expand Down Expand Up @@ -44,3 +44,4 @@ COPY entrypoint.sh /usr/local/bin/
# Setup the environment
ENV ZKSYNC_HOME=/usr/src/zksync
ENV PATH="${ZKSYNC_HOME}/bin:${PATH}"
ENV CI=1
6 changes: 0 additions & 6 deletions infrastructure/zk/src/completion.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// If the completion script is installed, there is no need to update it after adding a new subcommand

import { Command, Option } from 'commander';
import * as utils from './utils';
import tabtab from 'tabtab';

type CommandInfo = {
Expand Down Expand Up @@ -61,11 +60,6 @@ export function command(program: Command) {
name: 'zk',
completer: 'zk'
});
utils.replaceInFile(
`${process.env.HOME}/.config/tabtab/zk.bash`,
'zk completion --',
'zk completion'
);
});

completion
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/zk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ async function main() {
.addCommand(completion(program as Command));

// f command is special-cased because it is necessary
// that for it to run from $PWD and not from $ZKSYNC_HOME
// for it to run from $PWD and not from $ZKSYNC_HOME
program
.command('f <command...>')
.allowUnknownOption()
Expand Down
4 changes: 2 additions & 2 deletions infrastructure/zk/src/init.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ import * as env from './env';
import { up } from './up';

export async function init() {
await checkEnv();
await env.gitHooks();
if (!process.env.CI) {
await checkEnv();
await env.gitHooks();
await up();
}
await utils.allowFail(run.yarn());
Expand Down
2 changes: 1 addition & 1 deletion infrastructure/zk/src/test/integration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ export async function inDocker(command: string, timeout: number) {
timer.unref();

const volume = `${process.env.ZKSYNC_HOME}:/usr/src/zksync`;
const image = `matterlabs/ci-integration-test:latest`;
const image = `matterlabs/ci-integration-test:zk-latest`;
await utils.spawn(
`docker run -v ${volume} ${image} bash -c "/usr/local/bin/entrypoint.sh && ${command} || zk run cat-logs"`
);
Expand Down

0 comments on commit a306d95

Please sign in to comment.