[17.0][MIG] sign_oca: Migration to 17.0 #70
Conversation
[BOT] post-merge updates
[UPD] Update sign_oca.pot
Translated using Weblate (Italian) Currently translated at 28.2% (48 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/ Translated using Weblate (Italian) Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
[UPD] Update sign_oca.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/ Translated using Weblate (Italian) Currently translated at 100.0% (170 of 170 strings) Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/it/
[UPD] Update sign_oca.pot [BOT] post-merge updates Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sign-16.0/sign-16.0-sign_oca Translate-URL: https://translation.odoo-community.org/projects/sign-16-0/sign-16-0-sign_oca/
1. Add Sign button in request form (it was only in tree view). 2. Fix configure template action when it is created from a request.
… any user access to sign page TT41745
…expression) TT41745
- Load 'required' field in configure dialog - Show 'required' fields in red in configure mode - Load 'role_id' field in configure dialog
Unify to_sign and signer_is_allow_signature fields which had the same purpose
victoralmau
force-pushed
the
17.0-mig-sign_oca
branch
2 times, most recently
from
802230a to
2836af4
Compare
… sent to the signers so that everyone can sign Example use case: - Create a request - Define 2 different signers - Click on the Send button - 2 emails will be sent and each one will have the correct url in the Sign document button Fixes OCA#71
> > Co-authored-by: Bernat Puig <[email protected]>
victoralmau
force-pushed
the
17.0-mig-sign_oca
branch
from
2836af4 to
75d32b5
Compare
There was a problem hiding this comment.
Good morning,
During the functional review, I have detected an error:
When I enter inside the signature module, and click on configure of a template already created, it sends me the following error with traceability:
TypeError: Dialog.alert is not a function
at SignOcaConfigure.waitIframeLoaded (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:15167:193)
at http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:15168:289
And once the error closes, a message appears informing you that the pdf file is corrupt or invalid.
There was a problem hiding this comment.
During the functional testing, I have detected the following error.
When accessing one of the "sign requests," the "signed" button displays the following error:
KeyNotFoundError: Cannot find sign_oca_preview in this registry!
Error: Cannot find sign_oca_preview in this registry!
at Registry.get (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:3384:76)
at _executeClientAction (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10283:87)
at doAction (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10299:192)
at async Object.doActionButton (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10306:196)
at async execute (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:9930:293)
at async executeButtonCallback (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:9923:34)
Additionally, when selecting the "Activity log" button, another error appears:
EvalError: Can not evaluate python expression: ([("request_id", "=", id)])
Error: Name 'id' is not defined
EvalError: Can not evaluate python expression: ([("request_id", "=", id)])
Error: Name 'id' is not defined
at evaluateExpr (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:3058:54)
at _preprocessAction (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10216:150)
at doAction (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10298:170)
at async Object.doActionButton (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:10306:196)
at async execute (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:9930:293)
at async executeButtonCallback (http://oca-sign-17-0-pr70-75d32b584ed1.runboat.odoo-community.org/web/assets/4024fef/web.assets_web.min.js:9923:34)
|
Thank you for your comments, the PR is still in draft because we are finishing to solve the errors, it will be ready soon. |
|
I think that all problems are solved right now |
CarlosRoca13
force-pushed
the
17.0-mig-sign_oca
branch
from
7a6d5ca to
d9394ed
Compare
CarlosRoca13
force-pushed
the
17.0-mig-sign_oca
branch
from
d9394ed to
c291929
Compare
CarlosRoca13
force-pushed
the
17.0-mig-sign_oca
branch
from
c291929 to
d1ca0b4
Compare
CarlosRoca13
force-pushed
the
17.0-mig-sign_oca
branch
from
d1ca0b4 to
486549e
Compare
|
/ocabot migration sign_oca |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c321c16. Thanks a lot for contributing to OCA. ❤️ |
Supersedes #33
Migration to 17.0
@Tecnativa TT51500