libhb: add an helper function to check if an encoder supports two pas…

…ses or not. Enable two passes on VideoToolbox H.265 on Monterey on M1.
OMGUSED · Dec 27, 2021 · 6e2a48d · 6e2a48d
1 parent 87aec08
commit 6e2a48d
Show file tree

Hide file tree

Showing 4 changed files with 54 additions and 0 deletions.
diff --git a/libhb/common.c b/libhb/common.c
@@ -1500,6 +1500,33 @@ int hb_video_quality_is_supported(uint32_t codec)
     }
 }
 
+int hb_video_twopass_is_supported(uint32_t codec)
+{
+    switch (codec)
+    {
+#ifdef __APPLE__
+        case HB_VCODEC_VT_H264:
+        case HB_VCODEC_VT_H265:
+        case HB_VCODEC_VT_H265_10BIT:
+            return hb_vt_is_two_pass_available(codec);
+#endif
+
+        case HB_VCODEC_FFMPEG_MF_H264:
+        case HB_VCODEC_FFMPEG_MF_H265:
+        case HB_VCODEC_FFMPEG_VCE_H264:
+        case HB_VCODEC_FFMPEG_VCE_H265:
+        case HB_VCODEC_FFMPEG_NVENC_H264:
+        case HB_VCODEC_FFMPEG_NVENC_H265:
+        case HB_VCODEC_QSV_H264:
+        case HB_VCODEC_QSV_H265:
+        case HB_VCODEC_QSV_H265_10BIT:
+            return 0;
+
+        default:
+            return 1;
+    }
+}
+
 int hb_video_encoder_is_supported(int encoder)
 {
     const hb_encoder_t *video_encoder = NULL;

diff --git a/libhb/handbrake/common.h b/libhb/handbrake/common.h
@@ -408,6 +408,8 @@ void        hb_video_quality_get_limits(uint32_t codec, float *low, float *high,
 const char* hb_video_quality_get_name(uint32_t codec);
 int         hb_video_quality_is_supported(uint32_t codec);
 
+int         hb_video_twopass_is_supported(uint32_t codec);
+
 int                hb_video_encoder_is_supported(int encoder);
 int                hb_video_encoder_pix_fmt_is_supported(int encoder, int pix_fmt);
 int                hb_video_encoder_get_depth   (int encoder);

diff --git a/libhb/platform/macosx/vt_common.c b/libhb/platform/macosx/vt_common.c
@@ -168,6 +168,30 @@ int hb_vt_is_constant_quality_available(int encoder)
     return 0;
 }
 
+int hb_vt_is_two_pass_available(int encoder)
+{
+    switch (encoder)
+    {
+        case HB_VCODEC_VT_H264:
+        {
+            return 1;
+        }
+        case HB_VCODEC_VT_H265:
+        case HB_VCODEC_VT_H265_10BIT:
+        {
+#if defined(__aarch64__)
+            if (__builtin_available (macOS 12, *))
+            {
+                return 1;
+            }
+#endif
+            return 0;
+        }
+    }
+    return 0;
+
+}
+
 #pragma mark - Settings
 
 static const char * const vt_h26x_preset_name[] =

diff --git a/libhb/platform/macosx/vt_common.h b/libhb/platform/macosx/vt_common.h
@@ -11,6 +11,7 @@
 
 int hb_vt_is_encoder_available(int encoder);
 int hb_vt_is_constant_quality_available(int encoder);
+int hb_vt_is_two_pass_available(int encoder);
 
 const int* hb_vt_get_pix_fmts(int encoder);