Added links for keyword files in chapter 4.3 #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blattms
reviewed
Nov 26, 2024
| <text:p text:style-name="P59">There is no data required for this keyword.</text:p> | ||
| <text:p text:style-name="P59">All keywords between the SKIP<text:span text:style-name="T20">3</text:span>00 and ENDSKIP keywords are currently also ignored by OPM Flow. </text:p> | ||
| <text:p text:style-name="P59">The nesting of pairs of either the SKIP, SKIP100 or SKIP300 keyword and the ENDSKIP keyword is not supported by OPM Flow.</text:p> | ||
| <text:p text:style-name="P59">All keywords between the <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 and <text:a xlink:href="#__RefHeading___Toc605472_3199477706">ENDSKIP</text:a> keywords are currently also ignored by OPM Flow. </text:p> |
There was a problem hiding this comment.
I think here the initial formatting broke the link. The second one should go to SKIP300 and not SKIP
| @@ -4205,12 +4204,12 @@ Updated with AFR/TSA Rev-D comments and new keywords.</dc:description><meta:init | |||
| </table:table-row> | |||
| </table:table> | |||
| <text:h text:style-name="Heading_20_4" text:outline-level="4" text:is-list-header="true"><text:bookmark-start text:name="__RefHeading___Toc10367_37011683881711111"/>Description<text:bookmark-end text:name="__RefHeading___Toc10367_37011683881711111"/></text:h> | |||
| <text:p text:style-name="P59">The SKIP<text:span text:style-name="T20">3</text:span>00 keyword activates skipping of all keywords and input data by the commercial <text:span text:style-name="T20">compositional</text:span> simulator until the ENDSKIP keyword is encountered. All keywords between the SKIP<text:span text:style-name="T20">3</text:span>00 and ENDSKIP keywords are ignored by the commercial <text:span text:style-name="T20">compositional</text:span> simulator. The SKIP<text:span text:style-name="T20">3</text:span>00 keyword is ignored by the commercial <text:span text:style-name="T20">black-oil</text:span> simulator. Each SKIP<text:span text:style-name="T20">3</text:span>00 keyword should be paired with an ENDSKIP keyword. See also the SKIP and SKIP<text:span text:style-name="T20">1</text:span>00 keywords. <text:s/></text:p> | |||
| <text:p text:style-name="P59">The <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 keyword activates skipping of all keywords and input data by the commercial <text:span text:style-name="T20">compositional</text:span> simulator until the <text:a xlink:href="#__RefHeading___Toc605472_3199477706">ENDSKIP</text:a> keyword is encountered. All keywords between the <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 and <text:a xlink:href="#__RefHeading___Toc605472_3199477706">ENDSKIP</text:a> keywords are ignored by the commercial <text:span text:style-name="T20">compositional</text:span> simulator. The <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 keyword is ignored by the commercial <text:span text:style-name="T20">black-oil</text:span> simulator. Each <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 keyword should be paired with an <text:a xlink:href="#__RefHeading___Toc605472_3199477706">ENDSKIP</text:a> keyword. See also the <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a> and <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">1</text:span>00 keywords. <text:s/></text:p> | |||
There was a problem hiding this comment.
I think here the initial formatting SKIP<text:span ..>3</text:span>00 broke the link. The some links should go to SKIP300 and not SKIP
There was a problem hiding this comment.
Yes, good catch! I have updated the PR. I removed all span tags I could find related to SKIP100 and SKIP300 in SKIP300.fodt and then reapplied the script. Can you check again if I missed some?
| <text:h text:style-name="Heading_20_4" text:outline-level="4" text:is-list-header="true"><text:bookmark-start text:name="__RefHeading___Toc14501_37011683883711111"/>Example<text:bookmark-end text:name="__RefHeading___Toc14501_37011683883711111"/></text:h> | ||
| <text:p text:style-name="P60">If the following example is read using the commercial <text:span text:style-name="T20">compositional</text:span> simulator then the SKIP<text:span text:style-name="T20">3</text:span>00 keyword will cause the black-oil PVT data to be ignored, <text:span text:style-name="T20">the input will continue to be read after the next ENDSKIP keyword is encountered</text:span>, <text:span text:style-name="T20">and</text:span> the SKIP<text:span text:style-name="T20">1</text:span>00 keyword will be ignored and the compositional PVT data will be read <text:span text:style-name="T20">along with</text:span> the remainder of the <text:span text:style-name="T20">input</text:span>.</text:p> | ||
| <text:p text:style-name="P60">If the following example is read using the commercial <text:span text:style-name="T20">compositional</text:span> simulator then the <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">3</text:span>00 keyword will cause the black-oil PVT data to be ignored, <text:span text:style-name="T20">the input will continue to be read after the next <text:a xlink:href="#__RefHeading___Toc605472_3199477706">ENDSKIP</text:a> keyword is encountered</text:span>, <text:span text:style-name="T20">and</text:span> the <text:a xlink:href="#REF_HEADING_KEYWORD_SKIP_11_3">SKIP</text:a><text:span text:style-name="T20">1</text:span>00 keyword will be ignored and the compositional PVT data will be read <text:span text:style-name="T20">along with</text:span> the remainder of the <text:span text:style-name="T20">input</text:span>.</text:p> |
There was a problem hiding this comment.
I think here the initial formatting SKIP<text:span ..>3</text:span>00 broke the link. The some links should go to SKIP300 and not SKIP
hakonhagland
force-pushed
the
link4_3
branch
from
08e82c1 to
9d8e94b
Compare
Removed some span tags in SKIP300.fodt such that the keyword linker script would recognize the keyword. Then reapplied the linker script.
hakonhagland
force-pushed
the
link4_3
branch
from
9d8e94b to
c6a3a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used the script in #410 to add links to all keyword files in Chapter 4.3. See #410 for more information.