Script to check for erroneous links #442
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix link keywords script such that it does not add links inside office:binary sections. These sections contain image data encoded as base64, and should not be considered as normal text.
To avoid adding links from Figure captions, we check if we are inside a draw:frame element
Script to check for erroneous links in the office:binary-data sections
Thanks. I have also had a quick scan through chapters 4.3-11.3 and found very few images and didn't notice any obvious issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #441 which should be merged first.
This script checks for erroneously inserted links to keywords in the
office:binary-datasections in the keyword files. These links might have been inserted by the keyword linking script, see #435 (comment) for more information.I ran this script on chapters 4-11 and no erroneous links where detected there (according to this script). I will check chapter 12 next.