Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r.in.srtm: Fixed SIM115, FURB103, FLY002 by adding context manager, f-strings #5138

Merged
merged 2 commits into from
Feb 19, 2025
Merged

r.in.srtm: Fixed SIM115, FURB103, FLY002 by adding context manager, f-strings #5138

merged 2 commits into from
Feb 19, 2025

Conversation

arohanajit
Copy link
Contributor

Fixed multiple linting errors in r.in.srtm/

  • SIM115 - Added context manager
  • FURB103 - Added Path library to write the file
  • FLY002 - Used f-strings where applicable

echoix
echoix approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look wrong to me ;)

@petrasovaa petrasovaa enabled auto-merge (squash) February 18, 2025 18:26
@echoix
Copy link
Member

echoix commented Feb 18, 2025

I had restarted the windows job as v.colors unexpectedly failed the pytests , and the rerun works

@github-actions github-actions bot added raster Related to raster data processing Python Related code is in Python module labels Feb 18, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 18, 2025
View reviewed changes
scripts/r.in.srtm/r.in.srtm.py Dismissed Show resolved Hide resolved
@echoix echoix disabled auto-merge February 18, 2025 22:08
@wenzeslaus wenzeslaus changed the title scripts: Fixed SIM115, FURB103, FLY002 by adding context manager, f-strings in r.in.srtm/ r.in.srtm: Fixed SIM115, FURB103, FLY002 by adding context manager, f-strings Feb 19, 2025
@petrasovaa petrasovaa enabled auto-merge (squash) February 19, 2025 18:04
@petrasovaa petrasovaa merged commit bfe6ba0 into OSGeo:main Feb 19, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the 8.5.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenzeslaus wenzeslaus wenzeslaus left review comments

@echoix echoix echoix approved these changes

Assignees
No one assigned
Labels
module Python Related code is in Python raster Related to raster data processing
Projects
None yet
Milestone
8.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arohanajit @echoix @wenzeslaus @petrasovaa