Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MASTG-TEST-0036: Testing Enforced Updating (android) #3234

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

aakarshgopishetty
Copy link

Thank you for submitting a Pull Request to the OWASP MASTG. Please make sure that:

  • Your contribution is written in the 2nd person (e.g. you)
  • Your contribution is written in an active present form for as much as possible.
  • You have made sure that the reference section is up to date (e.g. please add sources you have used, make sure that the references to MITRE/MASVS/etc. are up to date)
  • Your contribution has proper formatted markdown and/or code
  • Any references to website have been formatted as [TEXT](URL “NAME”)
  • You verified/tested the effectiveness of your contribution (e.g.: is the code really an effective remediation? Please verify it works!)

If your PR is related to an issue. Please end your PR test with the following line:
This PR closes #2994.

Sorry, something went wrong.

@cpholguera cpholguera changed the title Enforced updating v2 Port MASTG-TEST-0036: Testing Enforced Updating (android) Mar 22, 2025
Copy link
Collaborator

@cpholguera cpholguera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't comply with our guidelines. Please check them out before proceeding. See our previous discussions here:

#2994 (comment)

#2999 (comment)

Turning into "DRAFT" until the files are compliant.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't belong to this PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't belong to this PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't comply with the required structure and style as defined in our guidelines. Please check them out before proceeding.

@cpholguera cpholguera marked this pull request as draft March 22, 2025 08:37
@aakarshgopishetty aakarshgopishetty marked this pull request as ready for review March 23, 2025 08:48
@aakarshgopishetty
Copy link
Author

@cpholguera I have removed unrelated files and fixed Markdown linting. Please review again. Thanks!

Copy link
Collaborator

@sk3l10x1ng sk3l10x1ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aakarshgopishetty kindly follow the structure and update changes accordingly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aakarshgopishetty

Here are the links to the guidelines as well as the specific guidelines for writing new tests and demos here:

https://docs.google.com/document/d/1EMsVdfrDBAu0gmjWAUEs60q-fWaOmDB5oecY9d9pOlg/edit?tab=t.0

Demo

Here’s an example of the demo folder structure:
https://github.com/OWASP/owasp-mastg/tree/f041b2c60afc81452095bd921e243309c817e292/demos/android/MASVS-PRIVACY/MASTG-DEMO-0033

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • This file doesn't belong to this PR , the MASTG-TEST-0036 is associated with this testcase

  • When dealing with "porting tests" issues, you won't be modifying the V1 tests. Instead, you'll mark them as deprecated and indicate the new tests to be used at the end of the metadata.

    status: deprecated
    covered_by: [MASTG-TEST-0x36]
    deprecation_note: New version available in MASTG V2
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MASTG v1->v2 MASTG-TEST-0036: Testing Enforced Updating (android)
3 participants