Skip to content

Commit

Permalink
rename hellworld-java to helloworld-java-spring (knative#1185)
Browse files Browse the repository at this point in the history
* rename hellworld-java to helloworld-java-spring

* updated sampleapp test

* Updated sample test app tmp directory

* Renamed service name and instructions to reflect helloworld-java-spring
  • Loading branch information
saturnism authored and knative-prow-robot committed Apr 23, 2019
1 parent 1d778b8 commit c60d695
Show file tree
Hide file tree
Showing 16 changed files with 12 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,15 @@ recreate the source files from this folder.
apiVersion: serving.knative.dev/v1alpha1
kind: Service
metadata:
name: helloworld-java
name: helloworld-java-spring
namespace: default
spec:
runLatest:
configuration:
revisionTemplate:
spec:
container:
image: docker.io/{username}/helloworld-java
image: docker.io/{username}/helloworld-java-spring
env:
- name: TARGET
value: "Spring Boot Sample v1"
Expand All @@ -143,10 +143,10 @@ folder) you're ready to build and deploy the sample app.

```shell
# Build the container on your local machine
docker build -t {username}/helloworld-java .
docker build -t {username}/helloworld-java-spring .
# Push the container to docker registry
docker push {username}/helloworld-java
docker push {username}/helloworld-java-spring
```

1. After the build has completed and the container is pushed to docker hub, you
Expand Down Expand Up @@ -196,14 +196,14 @@ folder) you're ready to build and deploy the sample app.
1. To find the URL for your service, use

```shell
kubectl get ksvc helloworld-java \
kubectl get ksvc helloworld-java-spring \
--output=custom-columns=NAME:.metadata.name,DOMAIN:.status.domain

NAME DOMAIN
helloworld-java helloworld-java.default.example.com
NAME DOMAIN
helloworld-java-spring helloworld-java-spring.default.example.com

# Or simply:
export DOMAIN_NAME=$(kubectl get ksvc helloworld-java \
export DOMAIN_NAME=$(kubectl get ksvc helloworld-java-spring \
--output jsonpath={.status.domain}
```
Expand Down
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
apiVersion: serving.knative.dev/v1alpha1
kind: Service
metadata:
name: helloworld-java
name: helloworld-java-spring
namespace: default
spec:
runLatest:
configuration:
revisionTemplate:
spec:
container:
image: docker.io/{username}/helloworld-java
image: docker.io/{username}/helloworld-java-spring
env:
- name: TARGET
value: "Spring Boot Sample v1"
4 changes: 2 additions & 2 deletions test/sampleapp/config.yaml
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
languages:
- language: "java"
- language: "java-spring"
expectedOutput: "Hello Spring Boot Sample v1!"
preCommands:
- exec: "curl"
args: "https://start.spring.io/starter.zip -d dependencies=web -d name=helloworld -d artifactId=helloworld -o helloworld.zip"
- exec: "unzip"
args: "helloworld.zip -d helloworld-java_tmp"
args: "helloworld.zip -d helloworld-java-spring_tmp"
- exec: "rm"
args: "helloworld.zip"
copies:
Expand Down

0 comments on commit c60d695

Please sign in to comment.