Changelog for squizlabs#2237 (ref squizlabs#2232)

OleksandrYemelianov · Nov 26, 2018 · ffefbcd · ffefbcd
1 parent 3be09c6
commit ffefbcd
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 33 deletions.
diff --git a/package.xml b/package.xml
@@ -116,6 +116,8 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Squiz.Commenting.InlineComment now has better detection of comment block boundaries
   - Squiz.Classes.ClassFileName now checks that a trait name matches the filename
     -- Thanks to Chris Wilkinson for the patch
+  - Squiz.Classes.SelfMemberReference now supports scoped declarations and anonymous classes
+    -- Thanks to Juliette Reinders Folmer for the patch
   - Squiz.Classes.SelfMemberReference now fixes multiple errors at once, increasing fixer performance
     -- Thanks to Gabriel Ostrolucký for the patch
   - Squiz.Functions.LowercaseFunctionKeywords now checks abstract and final prefixes, and auto-fixes errors

diff --git a/src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc b/src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc
@@ -135,17 +135,17 @@ class Baz {
 
 class Nested_Anon_Class {
     public function getAnonymousClass() {
-		// Spacing/comments should not cause false negatives for the NotUsed error.
+        // Spacing/comments should not cause false negatives for the NotUsed error.
         Nested_Anon_Class      ::       $prop;
-		Nested_Anon_Class
-		/* some comment */
+        Nested_Anon_Class
+        /* some comment */
 
-		::
+        ::
 
-		// phpcs:ignore Standard.Category.SniffName -- for reasons.
-		Bar();
+        // phpcs:ignore Standard.Category.SniffName -- for reasons.
+        Bar();
 
-		// Anonymous class is a different scope.
+        // Anonymous class is a different scope.
         return new class() {
             public function nested_function() {
                 Nested_Anon_Class::$prop;
@@ -157,18 +157,18 @@ class Nested_Anon_Class {
 
 // Test dealing with scoped namespaces.
 namespace Foo\Baz {
-	class BarFoo {
-		public function foo() {
-			echo Foo\Baz\BarFoo::$prop;
-		}
-	}
+    class BarFoo {
+        public function foo() {
+            echo Foo\Baz\BarFoo::$prop;
+        }
+    }
 }
 
 // Prevent false negative when namespace has whitespace/comments.
 namespace Foo /*comment*/ \ Bah {
-	class BarFoo {
-		public function foo() {
-			echo Foo \ /*comment*/ Bah\BarFoo::$prop;
-		}
-	}
+    class BarFoo {
+        public function foo() {
+            echo Foo \ /*comment*/ Bah\BarFoo::$prop;
+        }
+    }
 }
diff --git a/src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc.fixed b/src/Standards/Squiz/Tests/Classes/SelfMemberReferenceUnitTest.inc.fixed
@@ -125,15 +125,15 @@ class Baz {
 
 class Nested_Anon_Class {
     public function getAnonymousClass() {
-		// Spacing/comments should not cause false negatives for the NotUsed error.
+        // Spacing/comments should not cause false negatives for the NotUsed error.
               self::$prop;
-		
-		/* some comment */
+        
+        /* some comment */
 
-		self::// phpcs:ignore Standard.Category.SniffName -- for reasons.
-		Bar();
+        self::// phpcs:ignore Standard.Category.SniffName -- for reasons.
+        Bar();
 
-		// Anonymous class is a different scope.
+        // Anonymous class is a different scope.
         return new class() {
             public function nested_function() {
                 Nested_Anon_Class::$prop;
@@ -145,18 +145,18 @@ class Nested_Anon_Class {
 
 // Test dealing with scoped namespaces.
 namespace Foo\Baz {
-	class BarFoo {
-		public function foo() {
-			echo self::$prop;
-		}
-	}
+    class BarFoo {
+        public function foo() {
+            echo self::$prop;
+        }
+    }
 }
 
 // Prevent false negative when namespace has whitespace/comments.
 namespace Foo /*comment*/ \ Bah {
-	class BarFoo {
-		public function foo() {
-			echo   /*comment*/ self::$prop;
-		}
-	}
+    class BarFoo {
+        public function foo() {
+            echo   /*comment*/ self::$prop;
+        }
+    }
 }