forked from embedded2014/rtenv
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
1 changed file
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 6918bd0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this r7 has been stored in syscall (ex. line 8 @ syscall.s )
so this r7 is redundant.
but if I delete it, pop @ line 59 go wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since system call is invoked quite frequently, it is worthy to revise these lines. However, we only call something useless only when it has no impact to certain system designs.
If you think
r7
is useless, why don't you delete it and make it cleaner?