MDL-59970 competencies: performance

Remove useless get_records call in get_least_proficient_competencies_for_course function. On big sites this would cause huge memory usage.
Omegapoint · Nov 22, 2017 · 9a7671d · 9a7671d
1 parent 4275ea4
commit 9a7671d
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/competency/classes/user_competency_course.php b/competency/classes/user_competency_course.php
@@ -282,7 +282,6 @@ public static function get_least_proficient_competencies_for_course($courseid, $
               ORDER BY p.timesproficient ASC, c.id DESC';
 
         $results = $DB->get_records_sql($sql, $params, $skip, $limit);
-        $a = $DB->get_records_sql('SELECT * from {' . self::TABLE . '}');
 
         $comps = array();
         foreach ($results as $r) {