Added test for constructor returning no snippets when followed by 'other code'

[bbbscarter]

No description provided.

[nosami]

Ah.. I think this is the same issue as this OmniSharp/omnisharp-brackets#5

The problem is in this function

omnisharp-server/OmniSharp/AutoComplete/AutoCompleteHandler.cs

Line 78 in 64deb9d

private static bool IsInstantiating(AstNode nodeUnderCursor)

It doesn't always return true. Not sure what the fix is yet. That method is pretty hacky.

[mispencer]

NRefactory already returns whether the completion should return constructers. I am not sure why we are ignoring it in in favor of our own implemention.

[nosami]

Oooh... Did not know that. Could you link me to some code?
On 11 Nov 2014 19:46, "mispencer" [email protected] wrote:

NRefactory already returns whether the completion should return
constructers.

omnisharp-server/OmniSharp/AutoComplete/CompletionDataFactory.cs

Line 259 in 64deb9d

public ICompletionData CreateTypeCompletionData(IType type, bool showFullName, bool isInAttributeContext, bool addForTypeCreation)

I am not sure why we are ignoring it in in favor of our own implemention.

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

[nosami]

Sorry.....Just seen your link. I'm on a phone. Don't know why I never
noticed that before. Thanks!!
On 11 Nov 2014 19:46, "mispencer" [email protected] wrote:

NRefactory already returns whether the completion should return
constructers.

omnisharp-server/OmniSharp/AutoComplete/CompletionDataFactory.cs

Line 259 in 64deb9d

public ICompletionData CreateTypeCompletionData(IType type, bool showFullName, bool isInAttributeContext, bool addForTypeCreation)

I am not sure why we are ignoring it in in favor of our own implemention.

—
Reply to this email directly or view it on GitHub
#133 (comment)
.

[bbbscarter]

@mispencer We just tested with that flag and it failed here:

omnisharp-server/OmniSharp.Tests/AutoComplete/BugFixTests.cs

Line 103 in 64deb9d

public void Should_add_parentheses_to_class_when_instantiating()