Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build (xbuild): unused local variable in AutoComplete/SnippetGenerator.cs #164

Merged
merged 2 commits into from
Dec 8, 2014

Conversation

bodicsek
Copy link

@bodicsek bodicsek commented Dec 8, 2014

Buidling with xbuild (default settings) leads to a compile error.
This patch fixes it.

@nosami
Copy link
Contributor

nosami commented Dec 8, 2014

not sure what is going on here.... the build is passing on travis (which uses xbuild) https://travis-ci.org/OmniSharp/omnisharp-server

@nosami
Copy link
Contributor

nosami commented Dec 8, 2014

Your fix looks good though. Would like to know why this has been building on CI.

nosami added a commit that referenced this pull request Dec 8, 2014
Fixing build (xbuild): unused local variable in AutoComplete/SnippetGenerator.cs
@nosami nosami merged commit f60f0fe into OmniSharp:master Dec 8, 2014
@bodicsek
Copy link
Author

bodicsek commented Dec 8, 2014

I am not sure either. Treat it as a code clean up ;-)
I will get back to you with the proper version of mono and xbuild.

@nosami
Copy link
Contributor

nosami commented Dec 8, 2014

Yeah.. thanks! It needed doing.

@bodicsek
Copy link
Author

bodicsek commented Dec 8, 2014

WIth the debian wheezy mono install:
XBuild Engine Version 2.10.8.1
Mono, Version 2.10.8.1
AutoComplete/SnippetGenerator.cs(224,29): error CS0219: The variable `typeParams' is assigned but its value is never used

With mono snapshot 20140926154653:
XBuild Engine Version 12.0
Mono, Version 3.10.1.0
No compile error.

@nosami
Copy link
Contributor

nosami commented Dec 8, 2014

mono 2.10.8 isn't supported. There is a lot of odd behaviour with that version.

The last supported commit of omnisharp to support that version is https://github.com/OmniSharp/omnisharp-server/tree/mono-2.10.8

@bodicsek
Copy link
Author

bodicsek commented Dec 9, 2014

Thanks, I'll keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants