Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to pass configuration to /buildtarget #181

Merged
merged 1 commit into from
Feb 21, 2015

Conversation

jchannon
Copy link
Member

No description provided.

@@ -6,12 +6,20 @@ public class BuildTargetRequest : Request
{
public BuildType Type { get; set; }

public BuildConfiguration Configuration { get; set; }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to default to Debug

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will, just like Type does to Build because they're enums

On 19 February 2015 at 10:43, Jason Imison [email protected] wrote:

In OmniSharp/Build/BuildTargetRequest.cs
#181 (comment)
:

@@ -6,12 +6,20 @@ public class BuildTargetRequest : Request
{
public BuildType Type { get; set; }

  •    public BuildConfiguration Configuration { get; set; }
    

This needs to default to Debug

Reply to this email directly or view it on GitHub
https://github.com/OmniSharp/omnisharp-server/pull/181/files#r24978947.

@nosami
Copy link
Contributor

nosami commented Feb 21, 2015

Yep, of course. Cheers!

nosami added a commit that referenced this pull request Feb 21, 2015
ability to pass configuration to /buildtarget
@nosami nosami merged commit cebdc29 into OmniSharp:master Feb 21, 2015
@jchannon
Copy link
Member Author

Got this working but I think I am going to have to do another PR so you can do /p:Platform="Any CPU"

@nosami
Copy link
Contributor

nosami commented Feb 21, 2015

Think you're probably going to need to query for build targets thinking
about it.
On 21 Feb 2015 12:47, "Jonathan Channon" [email protected] wrote:

Got this working but I think I am going to have to do another PR so you
can do /p:Platform="Any CPU"


Reply to this email directly or view it on GitHub
#181 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants