Remove LowerCaseDriveLetter function #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes. You're absolutely right. This was a dirty hack that should never have been here. btw. This project is obsolete. This issue doesn't exist in omnisharp-roslyn. |
nosami
added a commit
that referenced
this pull request
Aug 29, 2015
Remove LowerCaseDriveLetter function
Whoa, that's news to me. :) Should ycmd migrate to omnisharp-roslyn? Is that ready for prime-time? |
homu
added a commit
to ycm-core/ycmd
that referenced
this pull request
Aug 30, 2015
[Windows support] Update OmniSharpServer submodule OmniSharp Server was modifying the drive letter case of paths causing test failures on ycmd side. This is fixed upstream (see PR OmniSharp/omnisharp-server#207) so we need to update the submodule. Fix 6 tests (1 error and 5 failures) on Windows (listed in the commit message).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the use of the
LowerCaseDriveLetterfunction. There are several issues with it:CandDdrive letters. What if another letter is used?