Yoast SEO - Gutenberg blocks translation - wpmltriage-2557 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strategio
reviewed
Mar 6, 2025
There was a problem hiding this comment.
@nicolasviallet, besides my comment, I noticed that we have a weird approach for maintaining Yoast SEO configs (see compdev-701).
I will keep your PR on hold until I fix it.
yoast-seo/wpml-config.xml
Outdated
| </key> | ||
| </key> | ||
| <xpath>//div/strong[contains(@class,"schema-faq-question")]</xpath> |
There was a problem hiding this comment.
@nicolasviallet, for the xpath entries, we can use a label attribute.
Could you please add it and check the rendering in ATE? (we should have human readable field labels)
|
@nicolasviallet, I've merged the 3 WordPress SEO configurations into 1 (#423). Please re-build your branch with your changes. Now all configuration changes should go to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yoast introduced Gutenberg blocks. They are already translatable in ATE. However, when opening the translation in the WP editor, the block will show a "Block contains unexpected or invalid content." message. When clicking the "Attempt recovery" button, the block loses its translation. That's because the block is translated but not the block attributes.