[Bug] Close the sectionPicker if the escape key is pressed #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice but avoiding statics by wrapping it in lifecycle management
leakymemory
reviewed
Feb 28, 2017
| @@ -5,4 +5,5 @@ node_modules | |||
| target/modules | |||
| target/tests | |||
| typings | |||
| debug.log | |||
There was a problem hiding this comment.
node generates it. I think I ran some invalid command. These were the contents of mine.
[0227/160250:ERROR:tcp_listen_socket.cc(76)] Could not bind socket to 127.0.0.1:6004
[0227/160250:ERROR:node_debugger.cc(86)] Cannot start debugger server
leakymemory
reviewed
Feb 28, 2017
| @@ -4,6 +4,7 @@ import {OneNotePickerPopupComponent} from "./oneNotePickerPopupComponent"; | |||
| import {SectionProps} from "./sectionComponent"; | |||
| import {ComponentBase} from "../componentBase"; | |||
| import {Status} from "../../status"; | |||
| import {Constants} from "../../constants"; | |||
There was a problem hiding this comment.
Nit: We should order the imports.
leakymemory
reviewed
Feb 28, 2017
target/oneNotePicker.js
Outdated
| OneNotePickerComponentClass.prototype.render = function () { | ||
| var status = this.getStatusEnumFromString(this.props.status); | ||
| var textToDisplay = this.getTextToDisplayFromStatus(status); | ||
| return ({tag: "div", attrs: {}, children: [ | ||
| // if (!OneNotePickerComponentClass.escapeListenerAttached) { |
There was a problem hiding this comment.
Is this code ready for review?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.