Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix null for objectParticipant in Task (#9752) #9755

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Conversation

Kedae
Copy link
Member

@Kedae Kedae commented Jan 29, 2025

Closes #9752

@Kedae Kedae added the filigran team use to identify PR from the Filigran team label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.39%. Comparing base (2941a40) to head (0fa94e8).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9755      +/-   ##
==========================================
+ Coverage   65.24%   65.39%   +0.14%     
==========================================
  Files         630      630              
  Lines       60315    60427     +112     
  Branches     6770     6887     +117     
==========================================
+ Hits        39354    39515     +161     
+ Misses      20961    20912      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Archidoit
Copy link
Member

Error when trying to add a participant :
image

@SarahBocognano
Copy link
Member

Same when trying to build frontend, the type [Participant!] and [Participant!]! are in conflict. I wasn't able to try it :(

@Kedae
Copy link
Member Author

Kedae commented Feb 3, 2025

Ready for a new review

@Kedae Kedae merged commit 9631bf9 into master Feb 3, 2025
9 checks passed
@Kedae Kedae deleted the issue/9752 branch February 3, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] When you try to add a participant, the message remains blocked.
3 participants