Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] fix file name in fintel template export form (#8336) #9807

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

Archidoit
Copy link
Member

@Archidoit Archidoit commented Feb 3, 2025

Last fixes for Fintel templates

  • fix export file name at fintel template export generation (from Content tab of a container)
  • changes in the Executive Summary built-in template

To test: be able to change the export file name when generating an html/pdf file from a fintel template

@Archidoit Archidoit added the filigran team use to identify PR from the Filigran team label Feb 3, 2025
@labo-flg
Copy link
Member

labo-flg commented Feb 3, 2025

tested locally ok

@Archidoit Archidoit merged commit ec7f09f into release/6.5.0 Feb 3, 2025
2 of 3 checks passed
@Archidoit Archidoit deleted the issue/8336-fix3 branch February 3, 2025 15:55
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.30%. Comparing base (3ab4762) to head (73cfa68).
Report is 5 commits behind head on release/6.5.0.

Additional details and impacted files
@@              Coverage Diff               @@
##           release/6.5.0    #9807   +/-   ##
==============================================
  Coverage          64.29%   64.30%           
==============================================
  Files                655      655           
  Lines              62860    62883   +23     
  Branches            6954     6967   +13     
==============================================
+ Hits               40414    40434   +20     
- Misses             22446    22449    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants