Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translated versinfo.cpp, toolbar8, allochan.cpp #51

Closed
wants to merge 2 commits into from
Closed

translated versinfo.cpp, toolbar8, allochan.cpp #51

wants to merge 2 commits into from

Conversation

0xeb
Copy link
Contributor

@0xeb 0xeb commented Apr 2, 2024

Please @janrysavy , let's get this moving fast.

janrysavy
janrysavy reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@janrysavy janrysavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some lower/upper case inconsistency, in some cases GPT-4 translation is better, some broken comment format. Overall, it looks very usable.

src/common/allochan.cpp

typedef void(__cdecl* _PVFV)(void);

#pragma section(".i_alc$a", read)
__declspec(allocate(".i_alc$a")) const _PVFV i_allochan = (_PVFV)1; // na zacatek sekce .i_alc si dame promennou i_allochan
__declspec(allocate(".i_alc$a")) const _PVFV i_allochan = (_PVFV)1; // at the beginning of the section, we will use the variable i_allochan for .i_alc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

// at the beginning of the .i_alc section, we put the variable i_allochan

see GPT-4 translation: https://chat.openai.com/share/020f2fca-fdef-4557-9218-5ef96f998d32

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"we put" vs "we use" ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean GPT-3.5 "at the beginning of the section ... for .i_alc" vs GPT-4 "at the beginning of the .i_alc section ..."

src/common/allochan.cpp
@@ -112,7 +113,7 @@ int C__AllocHandlerInit::AltapNewHandler(size_t size)
if (res == 0)
{
TRACE_ET(_T("AltapNewHandler: unable to open message-box!"));
Sleep(1000); // nechame masinu oddechnout a zkusime ukazat msgbox znovu
Sleep(1000); // Let the machine rest and try to show the msgbox again
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let -> let?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering that the old comment is gone and new English one is in, is it not more correct to capitalize first character?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to ensure this consistently, across multi-line comments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each "//" is translated on its own. I can attempt to write some logic to maintain capitalization or try to change my GPT prompt and see if it respects that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see first how much this is wasting our time or how really important that is, before I re-do that efforts.

src/toolbar8.cpp
@@ -58,8 +59,7 @@ BOOL CPluginsBar::CreatePluginButtons()
SetHotImageList(HPluginsIcons);

Plugins.InitPluginsBar(this);
/*
TLBI_ITEM_INFO2 tii;
/* TLBI_ITEM_INFO2 tii;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep original comment format.

src/toolbar8.cpp
InsertItem2(0xFFFFFFFF, TRUE, &tii);
}
*/
}*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep original comment format.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will keep an eye as I do my review next time for new files.

src/toolbar8.cpp

return TRUE;
}

int CPluginsBar::GetNeededHeight()
{
CALL_STACK_MESSAGE_NONE
// i v pripade, ze nedrzime zadnou ikonu budeem vracet spravnou vysku
// and in case we don't hold any icon, we will return the correct height
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and -> even

GPT-4 translation: https://chat.openai.com/share/7e2a3c00-cee9-411d-ad86-024a2406e9cb

src/versinfo.cpp
@@ -186,7 +187,7 @@ CVersionInfo::LoadBlock(const BYTE*& ptr, CVersionBlock* parent)
{
int valSize = info->wValueLength;

if (block->Type == vbtVersionInfo) // udelame par kontrol konzistence dat
if (block->Type == vbtVersionInfo) // Let's perform some consistency checks on the data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's -> let's

@0xeb
Copy link
Contributor Author

0xeb commented Apr 2, 2024

Let me propose this workflow:

  • I will give you commit access to my fork.
  • Directly edit the changes and commit back to my fork/branch
  • that will also reflect in the PR
  • once we are good, we go back to your main branch and merge?

Like this, we both get commit credits (open source spirit), and also, it will be faster since you know the language.

We are dealing with 15k comments and it is more efficient if you directly start editing instead of commenting.

How does that sound?

@janrysavy
Copy link
Contributor

I should probably start by reviewing and closing the existing pull requests. This is a manual translation, using GPT-4 combined with DeepL. Unfortunately, I am not able to focus on this this week and next week, because I need to finish work for Fine.

@0xeb
Copy link
Contributor Author

0xeb commented Apr 2, 2024

Manual GPT-4 is not going to be sustainable, not for anyone and not in any reasonable amount of time. I think it is fast to start off with the stuff I did, and just review / edit on the fly. It should take you (as a native speaker) no more than 10 minutes per file and we have around 170. So that's reasonable.

What is DeepL?

Please edit this PR at least per the workflow I suggested. They are 3 tiny files.

I need to start focusing on Unicode/UTF-16 support.

@0xeb
Copy link
Contributor Author

0xeb commented Apr 2, 2024

image Note the first and last lines in this screenshot. I can quickly write a script to update the translation based on the original text's first word if upper case or not. I will update that through and generate new translation files for new files (not these 3 files).

@0xeb 0xeb closed this Apr 4, 2024
@0xeb 0xeb deleted the translate001 branch April 4, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janrysavy janrysavy janrysavy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xeb @janrysavy