Val: video test stubs and media-proxy related fixtures #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tx/rx send mock implemented
* Moving validation application into a separate folder * Adding a base for functional testing using pytest * Fixtures to build the newest validation app (Lappka) * Class-based structure for JSON building --------- Co-authored-by: Bartosz Krystowski <[email protected]> Co-authored-by: marcin-le <[email protected]> Co-authored-by: Pomian, Karolina <[email protected]>
This reverts commit a6b8945.
MateuszGrabuszynski
requested review from
pwysock1-intel and
soopel
as code owners
skolelis
reviewed
Jan 21, 2025
skolelis
reviewed
Jan 21, 2025
skolelis
reviewed
Jan 21, 2025
…el(R) from Media Communications Mesh
andremiszcz
reviewed
Jan 22, 2025
| def remove_sent_file(file_path: str, app_path: str): | ||
| # filepath "/x/y/z.yuv", app_path "/a/b/" | ||
| # removes /a/b/z.yuv | ||
| removal_path = f'{app_path}/{file_path.split("/")[-1]}' |
There was a problem hiding this comment.
using Pathlib is more convenient I believe
There was a problem hiding this comment.
Yes, it is, let me change that, thanks for the suggestion :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add: stub for fixtures relating to media_proxy process lifecycle (spawning, killing)
Add: removal of sent file at the end of test to avoid disk full errors
Add: tests of mock for cluster and st2110 video transfers
Fix: wrong connection.st2110.transport value
Add: todos for further code extension
in tests/validation: Extending copyright with 2024-2025
in tests/validation: Removing 'Intel(R)' from Media Communications Mesh
Follow up to #296.