Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix driver installation script #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Fix driver installation script #316

wants to merge 2 commits into from

Conversation

staszczuk
Copy link
Collaborator

Found a bug when trying to install MCM dependencies. After running setup_ice_irdma.sh script (following the steps described in https://openvisualcloud.github.io/Media-Communications-Mesh/docs/README.html#getting-started):

sudo ./scripts/setup_ice_irdma.sh

there is an error:

INFO: Intel drivers: Starting download and patching actions.
ERROR:  MTL patch for ICE=v1.14.9 could not be found: /home/pstaszczuk/Media-Communications-Mesh/_build/mtl/patches/ice_drv/1.14.9
ERROR:  Intel drivers configuration/installation failed.

The script is trying to find MTL patches before MTL is downloaded.

Moved MTL download before checking the patches.

MateuszGrabuszynski
MateuszGrabuszynski previously approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@MateuszGrabuszynski MateuszGrabuszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the magic for me. 🧙🏼

@MateuszGrabuszynski MateuszGrabuszynski mentioned this pull request Jan 21, 2025
Open
Mionsz
Mionsz previously approved these changes Jan 21, 2025
View reviewed changes
@staszczuk staszczuk dismissed stale reviews from Mionsz and MateuszGrabuszynski via b4075be January 21, 2025 10:55
@MateuszGrabuszynski MateuszGrabuszynski enabled auto-merge (squash) January 21, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateuszGrabuszynski MateuszGrabuszynski MateuszGrabuszynski approved these changes

@pwysock1-intel pwysock1-intel Awaiting requested review from pwysock1-intel pwysock1-intel is a code owner

@soopel soopel Awaiting requested review from soopel soopel is a code owner

@Mionsz Mionsz Awaiting requested review from Mionsz

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@staszczuk @MateuszGrabuszynski @Mionsz