Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kr/big refactor #211

Merged
merged 21 commits into from
Dec 11, 2023
Merged

Kr/big refactor #211

merged 21 commits into from
Dec 11, 2023

Conversation

rocktavious
Copy link
Collaborator

Refactor the whole of the library so that its more maintainable but continues to work the same

Changelog

  • List your changes here
  • Make a changie entry

Tophatting

As seen in demo the commands service preview , service import and service reconcile still work the same. Additionall i've also updated service collect which is lesser known and used but it works.

@rocktavious rocktavious requested review from davidbloss and a user November 16, 2023 14:46
davidbloss
davidbloss previously approved these changes Nov 16, 2023
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@davidbloss davidbloss dismissed their stale review December 7, 2023 21:29

I need to re-review

src/cmd/config.go Outdated Show resolved Hide resolved
src/cmd/preview.go Outdated Show resolved Hide resolved
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One grammar comment but overall LGTM 🎉 🚀

src/common/reconciler_test.go Show resolved Hide resolved
src/common/reconciler_test.go Outdated Show resolved Hide resolved
src/cmd/preview.go Outdated Show resolved Hide resolved
src/cmd/config.go Outdated Show resolved Hide resolved
@rocktavious rocktavious merged commit 0aa2de0 into main Dec 11, 2023
3 checks passed
@rocktavious rocktavious deleted the kr/big-refactor branch December 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants