-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kr/big refactor #211
Merged
Merged
Kr/big refactor #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: taimoor ahmad <[email protected]>
c5cfe71
to
d622889
Compare
davidbloss
previously approved these changes
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
davidbloss
reviewed
Dec 8, 2023
davidbloss
reviewed
Dec 8, 2023
davidbloss
reviewed
Dec 8, 2023
davidbloss
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One grammar comment but overall LGTM 🎉 🚀
ghost
approved these changes
Dec 8, 2023
rocktavious
commented
Dec 8, 2023
rocktavious
commented
Dec 8, 2023
rocktavious
commented
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the whole of the library so that its more maintainable but continues to work the same
Changelog
changie
entryTophatting
As seen in demo the commands
service preview
,service import
andservice reconcile
still work the same. Additionall i've also updatedservice collect
which is lesser known and used but it works.