-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/mongodb unsupported char #113
Bugfix/mongodb unsupported char #113
Conversation
This is a breaking change for all who are using MongoDB as the database. It'll invalidate all collections that are using the unsupported characters in mongodump, mainly the |
Thanks. Will need to make a major upgrade and a notice about this on the README |
Quickfix/mongo dot unsupported
…t/node_acl into bugfix/mongodb-unsupported-char
hope this can be merged |
@manast Do you have a plan for a major upgrade including this ? |
Its mostly that this is a breaking change and many users will have big problems if they have not configured correctly their package.json |
@manast I understand this issue, but if this is blocking will this bugfix never be merged? |
I think the best way and maybe the only way to get this to be merged would be having a declarative to tell the module to use the correction or not and by default, it won't use it. Those that make sense? |
@jonmassot is making a good point there, @manast would you be ok with that? |
@jp either that or to implement this fix in a separate module such as the knex backend and others... |
Just adding my two cents that I would love to see this included in the next version. A project of mine is currently having to deal with this issue, and I'd really rather not have to monkey-patch. |
Breaking changes deserve a major version. A non default optional should be used for easy update/port/migration. |
Update on #228 Merging master and introducing a fallback flag. |
Reworking "Bugfix/mongodb unsupported char" (pull request #113)
Will there be a v5.x or a 4.11? Current npm repo is still on 4.10 without this patch. |
A simple fix to remove unsupported char in the collection name. That will solve the issue 53.