Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/mongodb unsupported char #113

Merged
merged 10 commits into from
Mar 20, 2017
Merged

Bugfix/mongodb unsupported char #113

merged 10 commits into from
Mar 20, 2017

Conversation

jonmassot
Copy link
Contributor

A simple fix to remove unsupported char in the collection name. That will solve the issue 53.

@jonmassot
Copy link
Contributor Author

This is a breaking change for all who are using MongoDB as the database. It'll invalidate all collections that are using the unsupported characters in mongodump, mainly the / and the space, but it could help solving the hassle of backing up all the ACL.

@manast
Copy link
Member

manast commented Apr 20, 2015

Thanks. Will need to make a major upgrade and a notice about this on the README

@gitawego
Copy link

hope this can be merged

@jp
Copy link

jp commented Aug 14, 2015

@manast Do you have a plan for a major upgrade including this ?

@manast
Copy link
Member

manast commented Aug 14, 2015

Its mostly that this is a breaking change and many users will have big problems if they have not configured correctly their package.json

@jp
Copy link

jp commented Aug 21, 2015

@manast I understand this issue, but if this is blocking will this bugfix never be merged?

@jonmassot
Copy link
Contributor Author

I think the best way and maybe the only way to get this to be merged would be having a declarative to tell the module to use the correction or not and by default, it won't use it. Those that make sense?

@jp
Copy link

jp commented Aug 21, 2015

@jonmassot is making a good point there, @manast would you be ok with that?

@manast
Copy link
Member

manast commented Aug 21, 2015

@jp either that or to implement this fix in a separate module such as the knex backend and others...

@ghost
Copy link

ghost commented Nov 2, 2015

Just adding my two cents that I would love to see this included in the next version. A project of mine is currently having to deal with this issue, and I'd really rather not have to monkey-patch.

@leodutra
Copy link
Contributor

Breaking changes deserve a major version. A non default optional should be used for easy update/port/migration.

@leodutra
Copy link
Contributor

Update on #228

Merging master and introducing a fallback flag.

@manast manast merged commit fb3a079 into OptimalBits:master Mar 20, 2017
manast added a commit that referenced this pull request Mar 20, 2017
Reworking "Bugfix/mongodb unsupported char" (pull request #113)
@Trenrod
Copy link

Trenrod commented May 5, 2017

Will there be a v5.x or a 4.11? Current npm repo is still on 4.10 without this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants