Skip to content

Commit

Permalink
Fix preview publishing (MetaMask#55)
Browse files Browse the repository at this point in the history
Preview publishing was broken because we were trying to use a short
commit hash as the `ref` to checkout with `actions/checkout@v3`. But
`actions/checkout@v3` only supports full commit hashes.

Instead we now pass it a full hash. Unfortunately this means that the
preview build URLs will be quite a bit longer, but hopefully this is
OK. If not, we can update this to generate both hashes.
  • Loading branch information
Gudahtt authored Mar 13, 2023
1 parent 7e03b41 commit d44ee2c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/publish-preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
PR_NUMBER: ${{ github.event.issue.number }}
- name: Get commit SHA
id: commit-sha
run: echo "COMMIT_SHA=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
run: echo "COMMIT_SHA=$(git rev-parse HEAD)" >> "$GITHUB_OUTPUT"
- name: Ensure commit hash is not empty
if: ${{ steps.commit-sha.outputs.COMMIT_SHA == '' }}
run: exit 1
Expand Down

0 comments on commit d44ee2c

Please sign in to comment.