add updateOption plugin event

Osub · Sep 21, 2017 · cd9a494 · cd9a494
1 parent caafd8e
commit cd9a494
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 8 deletions.
diff --git a/src/core/core.js b/src/core/core.js
@@ -658,6 +658,24 @@ class VConsole {
     this._triggerPluginEvent(this.activedTab, 'show');
   }
 
+  /**
+   * update option(s)
+   * @public
+   */
+  setOption(keyOrObj, value) {
+    if (tool.isString(keyOrObj)) {
+      this.option[keyOrObj] = value;
+      this._triggerPluginsEvent('updateOption');
+    } else if (tool.isObject(keyOrObj)) {
+      for (let k in keyOrObj) {
+        this.option[k] = keyOrObj[k];
+      }
+      this._triggerPluginsEvent('updateOption');
+    } else {
+      console.debug('The first parameter of vConsole.setOption() must be a string or an object.');
+    }
+  }
+
   /**
    * uninstall vConsole
    * @public

diff --git a/src/log/log.js b/src/log/log.js
@@ -20,6 +20,8 @@ import tplItem from './item.html';
 import tplFold from './item_fold.html';
 import tplFoldCode from './item_fold_code.html';
 
+const DEFAULT_MAX_LOG_NUMBER = 1000;
+
 class VConsoleLogTab extends VConsolePlugin {
 
   constructor(...args) {
@@ -34,7 +36,7 @@ class VConsoleLogTab extends VConsolePlugin {
     this.console = {};
     this.logList = []; // save logs before ready
     this.isInBottom = true; // whether the panel is in the bottom
-    this.maxLogNumber = 1000;
+    this.maxLogNumber = DEFAULT_MAX_LOG_NUMBER;
     this.logNumber = 0;
 
     this.mockConsole();
@@ -47,8 +49,7 @@ class VConsoleLogTab extends VConsolePlugin {
    */
   onInit() {
     this.$tabbox = $.render(this.tplTabbox, {});
-    this.maxLogNumber = this.vConsole.option.maxLogNumber || this.maxLogNumber;
-    this.maxLogNumber = Math.max(1, this.maxLogNumber);
+    this.updateMaxLogNumber();
   }
 
   /**
@@ -175,6 +176,32 @@ class VConsoleLogTab extends VConsolePlugin {
     }
   }
 
+  onUpdateOption() {
+    if (this.vConsole.option.maxLogNumber != this.maxLogNumber) {
+      this.updateMaxLogNumber();
+      this.limitMaxLogs();
+    }
+  }
+
+  updateMaxLogNumber() {
+    this.maxLogNumber = this.vConsole.option.maxLogNumber || DEFAULT_MAX_LOG_NUMBER;
+    this.maxLogNumber = Math.max(1, this.maxLogNumber);
+  }
+
+  limitMaxLogs() {
+    if (!this.isReady) {
+      return;
+    }
+    while (this.logNumber > this.maxLogNumber) {
+      let $firstItem = $.one('.vc-item', this.$tabbox);
+      if (!$firstItem) {
+        break;
+      }
+      $firstItem.parentNode.removeChild($firstItem);
+      this.logNumber--;
+    }
+  }
+
   showLogType(logType) {
     let $log = $.one('.vc-log', this.$tabbox);
     $.removeClass($log, 'vc-log-partly-log');
@@ -354,11 +381,7 @@ class VConsoleLogTab extends VConsolePlugin {
 
     // remove overflow logs
     this.logNumber++;
-    if (this.logNumber > this.maxLogNumber) {
-      let $firstItem = $.one('.vc-item', this.$tabbox);
-      $firstItem.parentNode.removeChild($firstItem);
-      this.logNumber--;
-    }
+    this.limitMaxLogs();
 
     // scroll to bottom if it is in the bottom before
     if (this.isInBottom) {