Fix/content streaming #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 17, 2015 13:58
Loading up file contents into StringIO causes memory starvation and kernel kills the process off. Therefore we are reverting to using plain file handles.
In addition to AttributeError, we also encounter cases where UnsupportedOperation exception is raised when seek() method is called on a file description (this is common with zipfile objects). This is now properly handled. We also needed to handle the case where offset was large enough to cause trouble for Librarian, and are now reading to offset in 1024 byte chunks.
This module is now part of bottle-fdsend package and no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.