Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GCSFSMap implementation #20

Merged
merged 5 commits into from
Jan 7, 2020
Merged

Add GCSFSMap implementation #20

merged 5 commits into from
Jan 7, 2020

Conversation

bgroenks96
Copy link
Contributor

@bgroenks96 bgroenks96 commented Oct 13, 2019 •
edited
Loading

Borrowed/adapted from S3FS implementation of S3Map

It seems like the unit tests can be pretty easily adapted from S3 as well, but I don't have time right now to set up gcloud credentials and a test bucket locally to do it.

Resolves #21

@birnbaum birnbaum self-requested a review January 7, 2020 12:52
birnbaum
birnbaum approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@birnbaum birnbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simplified the implementation for our purpose and added tests, as GCSFS already implements all the error handling and string parsing. Thanks for your help!

@birnbaum birnbaum merged commit cc18906 into Othoz:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@birnbaum birnbaum birnbaum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add equivalent of S3Map to gcsfs
2 participants
@bgroenks96 @birnbaum