Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raidboss: rename M[1-4] #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

xiashtra
Copy link
Collaborator

Follow community naming conventions for clarity.

Follow community naming conventions for clarity.
@xiashtra xiashtra enabled auto-merge (squash) July 24, 2024 02:17
@github-actions github-actions bot added auto-merge PR will be auto-merged upon approving review raidboss /ui/raidboss module needs-review Awaiting review labels Jul 24, 2024
@MaikoTan
Copy link
Collaborator

MaikoTan commented Jul 24, 2024

Well, just saw this post on reddit, and it is also more likely called R rather than M in Japanese folks. Personally I don't like to see them to be renamed like this sadly, though, I know it is hard to change everyone's thought. Here's just my own opinion about this.

@xiashtra
Copy link
Collaborator Author

xiashtra commented Jul 24, 2024

The NA pug raid discords community voted for M to be the naming convention some time ago, and that has been the more common nomenclature here. It also matches the in-game naming more closely (AAC Light-heavyweight M1, etc).

@xiashtra
Copy link
Collaborator Author

Well, just saw this post on reddit, and it is also more likely called R rather than M in Japanese folks. Personally I don't like to see them to be renamed like this sadly, though, I know it is hard to change everyone's thought. Here's just my own opinion about this.

I also note that that reddit post has no upvotes, and almost everyone in the comments is disagreeing with them.

@valarnin
Copy link
Collaborator

I look forward to next tier having M1 through M4 again, leading to massive confusion.

@MaikoTan
Copy link
Collaborator

I also note that that reddit post has no upvotes, and almost everyone in the comments is disagreeing with them.

Yeah, that's sad. 😞

@wexxlee
Copy link
Collaborator

wexxlee commented Jul 24, 2024

I've continued to see r1n-r4n nomenclature used predominantly elsewhere. The rationale seems to be that 'r' refers to ARcadion, whereas 'M' in the name refers to 'match', which makes it very likely that next tier (Cruiserweight) will reuse M1-M4, making the use of 'M' as a designator confusing. This seems to be supported by the localization strings for the zone names themselves: (Note that the german name actually uses 'R1', not 'M1', so another reason not to try to rely on 'match' as being unique across tiers):

1225: {
  'contentType': 5,
  'exVersion': 5,
  'name': {
    'de': 'Arkadion - Halbschwergewicht R1',
    'en': 'AAC Light-heavyweight M1',
    'fr': 'Poids mi-lourds CCA - match 1',
    'ja': '至天の座アルカディア:ライトヘビー級1',
  },
  'offsetX': -100,
  'offsetY': -100,
  'sizeFactor': 400,
  'weatherRate': 0,
},
1227: {
  'contentType': 5,
  'exVersion': 5,
  'name': {
    'de': 'Arkadion - Halbschwergewicht R2',
    'en': 'AAC Light-heavyweight M2',
    'fr': 'Poids mi-lourds CCA - match 2',
    'ja': '至天の座アルカディア:ライトヘビー級2',
  },
  'offsetX': -100,
  'offsetY': -100,
  'sizeFactor': 400,
  'weatherRate': 0,
},
1229: {
  'contentType': 5,
  'exVersion': 5,
  'name': {
    'de': 'Arkadion - Halbschwergewicht R3',
    'en': 'AAC Light-heavyweight M3',
    'fr': 'Poids mi-lourds CCA - match 3',
    'ja': '至天の座アルカディア:ライトヘビー級3',
  },
  'offsetX': -100,
  'offsetY': -100,
  'sizeFactor': 400,
  'weatherRate': 0,
},

My own $0.02, I'd prefer to leave as-is.

@wexxlee wexxlee disabled auto-merge July 24, 2024 03:28
@github-actions github-actions bot removed the auto-merge PR will be auto-merged upon approving review label Jul 24, 2024
@MaikoTan
Copy link
Collaborator

MaikoTan commented Jul 24, 2024

1225: {
  'contentType': 5,
  'exVersion': 5,
  'name': {
    'de': 'Arkadion - Halbschwergewicht R1',
    'en': 'AAC Light-heavyweight M1',
    'fr': 'Poids mi-lourds CCA - match 1',
    'ja': '至天の座アルカディア:ライトヘビー級1',
  },
  'offsetX': -100,
  'offsetY': -100,
  'sizeFactor': 400,
  'weatherRate': 0,
},

I see why people using M rather than R, so it turns out that there are no "R"-s in the English names. While German and Japanese do have the word Arcadion in their names.
(Japanese name literally translate: Ascension Seat of Arcadia : Light-heavywight 1)

wexxlee added a commit that referenced this pull request Jul 30, 2024
Resource file updates and content skeletons for Patch 7.05.  
This maintains parity with the current naming convention, but can be
updated later if #272 is merged (sidenote: if so, the oopsy trigger
files should also be renamed for both normal and savage.)
This also updates the current `effect_id.ts` file notwithstanding the
changes proposed in #286.
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Resource file updates and content skeletons for Patch 7.05.
This maintains parity with the current naming convention, but can be
updated later if #272 is merged (sidenote: if so, the oopsy trigger
files should also be renamed for both normal and savage.)
This also updates the current `effect_id.ts` file notwithstanding the
changes proposed in #286. 1be5017
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Resource file updates and content skeletons for Patch 7.05.
This maintains parity with the current naming convention, but can be
updated later if #272 is merged (sidenote: if so, the oopsy trigger
files should also be renamed for both normal and savage.)
This also updates the current `effect_id.ts` file notwithstanding the
changes proposed in #286. 1be5017
github-actions bot pushed a commit to AinaSnow/cactbot that referenced this pull request Jul 30, 2024
Resource file updates and content skeletons for Patch 7.05.
This maintains parity with the current naming convention, but can be
updated later if OverlayPlugin#272 is merged (sidenote: if so, the oopsy trigger
files should also be renamed for both normal and savage.)
This also updates the current `effect_id.ts` file notwithstanding the
changes proposed in OverlayPlugin#286. 1be5017
github-actions bot pushed a commit to AinaSnow/cactbot that referenced this pull request Jul 30, 2024
Resource file updates and content skeletons for Patch 7.05.
This maintains parity with the current naming convention, but can be
updated later if OverlayPlugin#272 is merged (sidenote: if so, the oopsy trigger
files should also be renamed for both normal and savage.)
This also updates the current `effect_id.ts` file notwithstanding the
changes proposed in OverlayPlugin#286. 1be5017
@ssilve1989
Copy link

There's already precedent for this type of naming convention all the way back in ARR. T1-13 even though each tier restarts as Turn 1-4(5) so it doesn't matter that next tier would be match 1-4 again. In traditional FF fashion, follow the first occurrence of something and stick with that pattern forever.

@Aho-Senpai
Copy link

That only happened for ARR raids though, and we all know ARR raids don't count =P

@wexxlee
Copy link
Collaborator

wexxlee commented Aug 5, 2024

Seeing more 'M' than 'R' these days. I still think 'r' is better internally for differentiation, but I'm retracting my earlier preference - I don't care either way.

@MaikoTan
Copy link
Collaborator

MaikoTan commented Aug 5, 2024

I don't think it bothers users many because most of them are just internal use, in most pages we are showing the full name of the raid to the user so they English players can always see the M-what at the end. :P

@jacob-keller
Copy link

I mostly see 'M', but I frequent mainly US/english places where that stuck pretty quick. My friends were confused by the 'R' and didn't seem to like it. I still think that 'M' may get confusing later on with new tiers.. I also don't think it makes a lot of difference what the internal names are.

@xiashtra
Copy link
Collaborator Author

I mostly see 'M', but I frequent mainly US/english places where that stuck pretty quick. My friends were confused by the 'R' and didn't seem to like it. I still think that 'M' may get confusing later on with new tiers.. I also don't think it makes a lot of difference what the internal names are.

The internal naming affects the configuration UI naming, which would be the main motivation for changing the naming scheme. An alternative may be to use the zoneLabel property to provide "localized" naming schemes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Awaiting review raidboss /ui/raidboss module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants