raidemulator: Minor tweaks and >8 player support #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `Hide General` triggers option Remove 8-player restriction
github-actions
bot
added
needs-review
wexxlee
approved these changes
Jan 5, 2025
github-actions bot
pushed a commit
to ShadyWhite/cactbot
that referenced
this pull request
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on chaotic finally reminded me that the 8-player restriction still existed in raidemulator. Also I got tired of looking at the general
Provoke/Shirktriggers while testing/debugging, so added an option to hide general triggers.mapelement to make space for more playersHide Generaltriggers checkboxThe timeline bar at the top will still only show the first 8 players' triggers for now. I left an
@TODOcomment inEmulatedPartyInfo.tsfor this.