Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IcalParser.php #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update IcalParser.php #30

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 22, 2018

fix calculation of event recurrences depending on the current date (and not on event start date)

fix calculation of event recurrences depending on the current date (and not on event start date)
@OzzyCzech
Copy link
Owner

will be possible fix failing tests (./vendor/bin/tester tests)

./vendor/bin/tester tests/
 _____ ___  ___ _____ ___  ___
|_   _/ __)( __/_   _/ __)| _ )
  |_| \___ /___) |_| \___ |_|_\  v2.0.1

Note: Default interpreter is CLI since Tester v2.0. It used to be CGI.
Note: No php.ini is used.
PHP 7.2.4 (cli) | php -n | 8 threads

...F...

-- FAILED: recurring_events.phpt
   Failed: 40 should be equal to 35
   
   in icalparser/tests/recurring_events.phpt(48) Assert::equal(35, sizeof($recurrences));


FAILURES! (7 tests, 1 failure, 0.1 seconds)

@OzzyCzech
Copy link
Owner

Hi, will be possible fix tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants