My FC work #12
Open
My FC work #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly close websocket API connection
Update a comment to avoid confusing doxygen
CMake cleanup & MinGW support
Add macOS to Github Autobuild
This reverts commit 0cf6f46
Issue-13-fix (websocket shutdown) See merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!17
ws-updates See merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!18
This file was originally added in ff09920
For some reason, the websocket_server types have been altered to require an X-Forwarded-For header (???) which seems utterly unnecessary. AFAICT, it's safe to just leave it empty (BitShares does), so add a default arg to make it do so by default.
This reverts commit 1dcacba.
Feature/readline-editline See merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!20
static variant update See merge request PBSA/PeerplaysIO/tools-libs/peerplays-fc!19
This is just a rote copy of vendor/websocketpp from two commits ago, ie 0e92594
Remove as much warnings from build log as possible
Also, fix build: Clang 10.0.1 has incompatible rules with other compilers on whether you must/cannot put the `template` keyword in part of the reflection code. Add a special case to make it work all around.
|
@nathanhourt - can you send the same to gitlab so that the CI gets kicked in ? We need to merge this as there is more sidechain work just started and want to use this FC changes. Just send the MR in gitlab and I guess we will find a way to quickly merge it |
It broke again so poke it again. Perhaps all clang versions require `template` here? I'm not sure, haven't gotten around to testing all the different compilers on it yet.
Merge with latest-fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the latest of my FC work, including my merges from BitShares FC and some new work I've done on top to support my ongoing development.