This repository was archived by the owner on Jan 2, 2019. It is now read-only.
Fixed hidden columns for Chome #613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden columns were working only for columns with set width. I moved it outside of "if" so these two things are not connected now.. Also it was not working in Chrome at all because of this bug -> https://code.google.com/p/chromium/issues/detail?id=174167 Chrome doesn't support visibility:collapse and in fact any kid of visibility for "col" tag. Maybe there is better workout than display:none on .column class but I haven't found one. $css['table.sheet' . $sheetIndex . ' col.col' . $column]['display'] = 'none' is not working in Chrome
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden columns were working only for columns with set width. I moved it outside of "if" so these two things are not connected now..
Also it was not working in Chrome at all because of this bug -> https://code.google.com/p/chromium/issues/detail?id=174167
Chrome doesn't support visibility:collapse and in fact any kid of visibility for "col" tag.
Maybe there is better workout than display:none on .column class but I haven't found one.
$css['table.sheet' . $sheetIndex . ' col.col' . $column]['display'] = 'none' is not working in Chrome