Worksheet title invalid character check comparison

[willselby]

Changed the comparison operator in Worksheet.php _checkSheetTitle() method from !== to !=, otherwise using an integer as a worksheet name throws this exception.

[MarkBaker]

Except that a worksheet title should be a string

[willselby]

What's wrong with having an integer as a worksheet title?

I need to create worksheets for years from the keys of an array as in; [2001, 2002, 2003]. Excel is perfectly happy with this, but this method causes them to throw an exception. I could go through the array and explicitly declare each as a string, but if the user checks the array of invalid characters then it isn't immediately obvious why this has failed.

If we insist on the title being a string then we could add; $pValue = (string) $pValue; within the method to take the responsibility of this away from the user.

Just thought this would make the life of the end user easier.

[MarkBaker]

Excel isn't happy as you think.... effectively you're creating worksheets for['2001', '2002', '2003']not for[2001, 2002, 2003]`; because Excel worksheet names are strings, even if they're strings comprising all digits. Casting to a string is probably a better option than loosening the validation rules

[willselby]

Ah ok, I was assuming it was happy working with integers rather than converting them to strings. In that case I think you're right about casting to strings rather than loosening the validation.