Skip to content

Commit

Permalink
ihex: add support for CS:IP/EIP records
Browse files Browse the repository at this point in the history
ihex firmwares can include a jump address for starting execution.  Add a
-j option which will cause this to be written into the generated file as a
record with address zero and data consisting of the address to jump to,
allowing drivers to make use of this information.

This format is chosen because it most closely follows the original ihex
format, though it may make more sense to write a record with length zero
and the address stored as the address.  The records are not omitted by
default since our ihex format does not include record type information and
so including additional records may lead to confusion.

Signed-off-by: Mark Brown <[email protected]>
Cc: David Woodhouse <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
broonie authored and torvalds committed Oct 26, 2010
1 parent b6777c4 commit 2473238
Showing 1 changed file with 14 additions and 3 deletions.
17 changes: 14 additions & 3 deletions firmware/ihex2fw.c
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ static int output_records(int outfd);

static int sort_records = 0;
static int wide_records = 0;
static int include_jump = 0;

static int usage(void)
{
Expand All @@ -63,6 +64,7 @@ static int usage(void)
fprintf(stderr, "usage: ihex2fw [<options>] <src.HEX> <dst.fw>\n");
fprintf(stderr, " -w: wide records (16-bit length)\n");
fprintf(stderr, " -s: sort records by address\n");
fprintf(stderr, " -j: include records for CS:IP/EIP address\n");
return 1;
}

Expand All @@ -73,15 +75,17 @@ int main(int argc, char **argv)
uint8_t *data;
int opt;

while ((opt = getopt(argc, argv, "ws")) != -1) {
while ((opt = getopt(argc, argv, "wsj")) != -1) {
switch (opt) {
case 'w':
wide_records = 1;
break;
case 's':
sort_records = 1;
break;
default:
case 'j':
include_jump = 1;
break;
return usage();
}
}
Expand Down Expand Up @@ -128,6 +132,7 @@ static int process_ihex(uint8_t *data, ssize_t size)
{
struct ihex_binrec *record;
uint32_t offset = 0;
uint32_t data32;
uint8_t type, crc = 0, crcbyte = 0;
int i, j;
int line = 1;
Expand Down Expand Up @@ -223,8 +228,14 @@ static int process_ihex(uint8_t *data, ssize_t size)
return -EINVAL;
}

memcpy(&data32, &record->data[0], sizeof(data32));
data32 = htonl(data32);
memcpy(&record->data[0], &data32, sizeof(data32));

/* These records contain the CS/IP or EIP where execution
* starts. Don't really know what to do with them. */
* starts. If requested output this as a record. */
if (include_jump)
file_record(record);
goto next_record;

default:
Expand Down

0 comments on commit 2473238

Please sign in to comment.