fix imagenet-100 and orthognality metric bugs

PKU-ML · Apr 5, 2024 · cf6a837 · cf6a837
1 parent 0554940
commit cf6a837
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/scripts/pretrain/imagenet-100/ncl.yaml b/scripts/pretrain/imagenet-100/ncl.yaml
@@ -11,7 +11,7 @@ hydra:
   run:
     dir: .
 
-name: "simclr-imagenet100"
+name: "simclr-imagenet100-ncl"
 method: "simclr"
 backbone:
   name: "resnet18"
@@ -24,7 +24,7 @@ method_kwargs:
   learn_temp: 0
   normalize: dim
   tau: 1
-  non_neg: non_neg
+  non_neg: relu
 data:
   dataset: imagenet100
   train_path: "imagenet100/train"

diff --git a/scripts/pretrain/imagenet-100/simclr.yaml b/scripts/pretrain/imagenet-100/simclr.yaml
@@ -24,7 +24,7 @@ method_kwargs:
   learn_temp: 0
   normalize: dim
   tau: 1
-  non_neg: none
+  non_neg: None
 data:
   dataset: imagenet100
   train_path: "imagenet100/train"

diff --git a/scripts/pretrain/imagenet-100/wandb/private.yaml b/scripts/pretrain/imagenet-100/wandb/private.yaml
@@ -1,3 +1,3 @@
 enabled: True
 entity: null
-project: "solo-nmf"
+project: "non_neg"
diff --git a/solo/methods/simclr.py b/solo/methods/simclr.py
@@ -250,7 +250,7 @@ def semantic_consistency(features, labels, eps=1e-5, take_abs=False, topk=False)
             logger("semantic_consistency", semantic_consistency(z, targets), on_epoch=True, sync_dist=True)
 
         def orthogonality(features, eps=1e-5):
-            features  = features[:,features.sum(0)>10]
+            features  = features[:,features.abs().sum(0)>0]
             n, d = features.shape
             features = F.normalize(features, dim=0)
             corr = features.T @ features