Format Imports using Isort (ManimCommunity#1178)

* Format imports using Isort.
Add a check for pull requests.

Signed-off-by: Naveen M K <[email protected]>

* CI: update check's name

.github/workflows/lint.yml

@@ -88,3 +88,22 @@ jobs:
       - name: Run Flake8
         run: |
           poetry run flake8 manim
+
+  isort-checks:
+    runs-on: windows-latest
+    steps:
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: 3.9
+
+      - name: Checkout the repository
+        uses: actions/checkout@v2
+
+      - name: Install Dependencies
+        run: |
+          pip install isort
+
+      - name: Run Isort
+        run: |
+          isort -c .

docs/source/manim_directive.py

@@ -72,17 +72,16 @@ def construct(self):
         that is rendered in a reference block after the source code.
 
 """
-from docutils import nodes
-from docutils.parsers.rst import directives, Directive
-from docutils.statemachine import StringList
-
-import jinja2
 import os
+import shutil
 from os.path import relpath
 from pathlib import Path
 from typing import List
 
-import shutil
+import jinja2
+from docutils import nodes
+from docutils.parsers.rst import Directive, directives
+from docutils.statemachine import StringList
 
 from manim import QUALITIES
 

example_scenes/opengl.py

@@ -1,8 +1,8 @@
-from manim import *
-from manim.opengl import *
 import os
 from pathlib import Path
 
+from manim import *
+from manim.opengl import *
 
 # Copied from https://3b1b.github.io/manim/getting_started/example_scenes.html#surfaceexample.
 # Lines that do not yet work with the Community Version are commented.

manim/__init__.py

@@ -11,11 +11,6 @@
 # Importing the config module should be the first thing we do, since other
 # modules depend on the global config dict for initialization.
 from ._config import *
-
-from .constants import *
-
-from .container import *
-
 from .animation.animation import *
 from .animation.composition import *
 from .animation.creation import *
@@ -28,24 +23,23 @@
 from .animation.transform import *
 from .animation.transform_matching_parts import *
 from .animation.update import *
-
-from .renderer.cairo_renderer import *
-
 from .camera.camera import *
 from .camera.mapping_camera import *
 from .camera.moving_camera import *
-from .camera.three_d_camera import *
 from .camera.multi_camera import *
-
-from .mobject.coordinate_systems import *
+from .camera.three_d_camera import *
+from .constants import *
+from .container import *
 from .mobject.changing import *
+from .mobject.coordinate_systems import *
 from .mobject.frame import *
 from .mobject.functions import *
 from .mobject.geometry import *
 from .mobject.graph import *
 from .mobject.logo import *
 from .mobject.matrix import *
 from .mobject.mobject import *
+from .mobject.mobject_update_utils import *
 from .mobject.number_line import *
 from .mobject.numbers import *
 from .mobject.probability import *
@@ -62,42 +56,39 @@
 from .mobject.types.image_mobject import *
 from .mobject.types.point_cloud_mobject import *
 from .mobject.types.vectorized_mobject import *
-from .mobject.mobject_update_utils import *
 from .mobject.value_tracker import *
 from .mobject.vector_field import *
-
+from .renderer.cairo_renderer import *
 from .scene.graph_scene import *
 from .scene.moving_camera_scene import *
 from .scene.reconfigurable_scene import *
-
-from .scene.scene import *
 from .scene.sample_space_scene import *
+from .scene.scene import *
+from .scene.scene_file_writer import *
 from .scene.three_d_scene import *
 from .scene.vector_space_scene import *
 from .scene.zoomed_scene import *
-from .scene.scene_file_writer import *
-
+from .utils import color as color
+from .utils import rate_functions, unit
 from .utils.bezier import *
 from .utils.color import *
-from .utils import color as color
 from .utils.config_ops import *
 from .utils.debug import *
+from .utils.file_ops import *
 from .utils.images import *
 from .utils.iterables import *
-from .utils.file_ops import *
 from .utils.paths import *
 from .utils.rate_functions import *
-from .utils import rate_functions
 from .utils.simple_functions import *
 from .utils.sounds import *
 from .utils.space_ops import *
 from .utils.strings import *
 from .utils.tex import *
 from .utils.tex_templates import *
-from .utils import unit
 
 try:
     from IPython import get_ipython
+
     from .utils.ipython_magic import ManimMagic
 except ImportError:
     pass

manim/__main__.py

@@ -1,12 +1,13 @@
 import sys
+
 import click
 from click_default_group import DefaultGroup
+
 from . import __version__, console
-from .constants import EPILOG
-from .constants import CONTEXT_SETTINGS
 from .cli.cfg.commands import cfg
 from .cli.plugins.commands import plugins
 from .cli.render.commands import render
+from .constants import CONTEXT_SETTINGS, EPILOG
 
 
 def exit_early(ctx, param, value):

manim/_config/utils.py

@@ -12,9 +12,9 @@
 import argparse
 import configparser
 import copy
+import errno
 import logging
 import os
-import errno
 import sys
 import typing
 from collections.abc import Mapping, MutableMapping

manim/animation/animation.py

@@ -5,20 +5,19 @@
 
 
 import typing
-from typing import Union
 from copy import deepcopy
+from typing import Union
 
 import numpy as np
 
 if typing.TYPE_CHECKING:
     from manim.scene.scene import Scene
 
 from .. import logger
-from ..mobject import mobject
-from ..mobject import opengl_mobject
+from ..mobject import mobject, opengl_mobject
 from ..mobject.mobject import Mobject
-from ..utils.rate_functions import smooth
 from ..mobject.opengl_mobject import OpenGLMobject
+from ..utils.rate_functions import smooth
 
 DEFAULT_ANIMATION_RUN_TIME: float = 1.0
 DEFAULT_ANIMATION_LAG_RATIO: float = 0.0

manim/animation/creation.py

@@ -76,17 +76,17 @@ def construct(self):
 
 import numpy as np
 from colour import Color
-from .. import logger
 
+from .. import logger
 
 if typing.TYPE_CHECKING:
     from manim.mobject.svg.text_mobject import Text
 
 from ..animation.animation import Animation
 from ..animation.composition import Succession
 from ..mobject.mobject import Group, Mobject
-from ..mobject.types.vectorized_mobject import VMobject
 from ..mobject.types.opengl_vectorized_mobject import OpenGLVMobject
+from ..mobject.types.vectorized_mobject import VMobject
 from ..utils.bezier import integer_interpolate
 from ..utils.rate_functions import double_smooth, linear, smooth
 

manim/animation/fading.py

@@ -75,8 +75,8 @@ def construct(self):
 from ..animation.transform import Transform
 from ..constants import DOWN, ORIGIN
 from ..mobject.mobject import Group
-from ..mobject.types.vectorized_mobject import VMobject
 from ..mobject.types.opengl_vectorized_mobject import OpenGLVMobject
+from ..mobject.types.vectorized_mobject import VMobject
 from ..utils.bezier import interpolate
 from ..utils.rate_functions import there_and_back
 

manim/animation/transform_matching_parts.py

@@ -3,16 +3,16 @@
 __all__ = ["TransformMatchingShapes", "TransformMatchingTex"]
 
 
-import numpy as np
 from typing import List, Optional
 
-from .composition import AnimationGroup
-from .fading import FadeInFromPoint, FadeOutToPoint
-from .transform import Transform, ReplacementTransform, FadeTransformPieces
+import numpy as np
 
-from ..mobject.mobject import Mobject, Group
-from ..mobject.types.vectorized_mobject import VGroup, VMobject
+from ..mobject.mobject import Group, Mobject
 from ..mobject.svg.tex_mobject import MathTex
+from ..mobject.types.vectorized_mobject import VGroup, VMobject
+from .composition import AnimationGroup
+from .fading import FadeInFromPoint, FadeOutToPoint
+from .transform import FadeTransformPieces, ReplacementTransform, Transform
 
 
 class TransformMatchingAbstractBase(AnimationGroup):

manim/camera/camera.py

@@ -3,30 +3,29 @@
 
 __all__ = ["Camera", "BackgroundColoredVMobjectDisplayer"]
 
-from functools import reduce
+import copy
 import itertools as it
 import operator as op
 import time
-import copy
+from functools import reduce
 
-from PIL import Image
-from scipy.spatial.distance import pdist
 import cairo
 import numpy as np
+from PIL import Image
+from scipy.spatial.distance import pdist
 
-from .. import logger, config
+from .. import config, logger
 from ..constants import *
-from ..mobject.types.image_mobject import AbstractImageMobject
 from ..mobject.mobject import Mobject
+from ..mobject.types.image_mobject import AbstractImageMobject
 from ..mobject.types.point_cloud_mobject import PMobject
 from ..mobject.types.vectorized_mobject import VMobject
 from ..utils.color import color_to_int_rgba
+from ..utils.family import extract_mobject_family_members
 from ..utils.images import get_full_raster_image_path
 from ..utils.iterables import list_difference_update
 from ..utils.simple_functions import fdiv
-from ..utils.space_ops import angle_of_vector
-from ..utils.space_ops import get_norm
-from ..utils.family import extract_mobject_family_members
+from ..utils.space_ops import angle_of_vector, get_norm
 
 
 class Camera:

manim/camera/webgl_camera.py

@@ -1,6 +1,7 @@
-from .camera import Camera
 import copy
 
+from .camera import Camera
+
 
 class WebGLCamera(Camera):
     def __init__(self, **kwargs):

manim/cli/cfg/commands.py

@@ -6,17 +6,16 @@
 
 """
 import os
-import click
-
 from ast import literal_eval
 from typing import Union
+
+import click
 from rich.errors import StyleSyntaxError
 from rich.style import Style
 
 from ... import config, console
-from ...constants import EPILOG
-from ...constants import CONTEXT_SETTINGS
 from ..._config.utils import config_file_paths, make_config_parser
+from ...constants import CONTEXT_SETTINGS, EPILOG
 from ...utils.file_ops import guarantee_existence, open_file
 
 RICH_COLOUR_INSTRUCTIONS: str = """

manim/cli/plugins/commands.py

@@ -7,9 +7,7 @@
 """
 import click
 
-from ...constants import EPILOG
-from ...constants import CONTEXT_SETTINGS
-
+from ...constants import CONTEXT_SETTINGS, EPILOG
 from ...plugins.plugins_flags import list_plugins
 
 

manim/cli/render/commands.py

@@ -12,13 +12,13 @@
 import click
 import cloup
 
+from ... import config, console, logger
+from ...constants import CONTEXT_SETTINGS, EPILOG
+from ...utils.module_ops import scene_classes_from_file
 from .ease_of_access_options import ease_of_access_options
 from .global_options import global_options
 from .output_options import output_options
 from .render_options import render_options
-from ... import config, console, logger
-from ...constants import CONTEXT_SETTINGS, EPILOG
-from ...utils.module_ops import scene_classes_from_file
 
 
 @cloup.command(

manim/cli/render/global_options.py

@@ -1,7 +1,6 @@
 import click
 from cloup import option, option_group
 
-
 global_options = option_group(
     "Global options",
     option(

manim/container.py

@@ -8,6 +8,7 @@
 
 
 from abc import ABC, abstractmethod
+
 from . import logger