-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CBO June 2024 update #2831
CBO June 2024 update #2831
Conversation
Merge pull request PSLmodels#2752 from bodiyang/master
4.0.0 merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2831 +/- ##
=======================================
Coverage 99.42% 99.42%
=======================================
Files 13 13
Lines 2619 2619
=======================================
Hits 2604 2604
Misses 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. |
@bodiyang, I have two questions to start with: (1) If you are updating using the new CBO 2024+ projections, why are the historical results as far back as 2021 changing? Why are you revising HISTORY? (2) If you are updating using the new CBO 2024+ projections, why are the 2024+ contents |
For (1): It is because CBO themselves revised the baseline value for the previous years in June 2024 publication. Same can be seen in Tax-data's CBO_baseline.csv. This file shows the baseline difference between June 2024 publication and Feb 2024 publication. |
I'm also having recheck on growth factors now. Will send updates later |
OK. What is the answer to my question (2)? |
There has been a new update from BLS for CPI in September, which will affect the growth factor, baseline, ... files. I will make another update in Tax-Data and incorporate the change in this Tax-Calculator PR. |
@bodiyang said:
I don't understand. Are you saying CBO did not change its economic projections in the June report? Why are you planning to change only the CPI projection? Also, if you change the CPI projection in |
CBO changed its economic projections in the June report and it has already been reflected in this June report. The "CBO update process" in Tax-Data actually also includes the updates from BLS. details can be found at updatecbo.py I completed the CBO update process in Tax-Data in August, but I just noticed that BLS has made an update in CPI (which will affect the And thanks for bringing up the taxdata issue #444 , I will do the update from there. |
@bodiyang said:
This sentence makes no sense to me. When I look at taxdata |
In a conclusion, I will make another update in Tax-Data with the new changes, including growth factors, soon. Would make sense to wait a lit bit as I'm finalizing it. |
@jdebacker @martinholmer This PR is ready for review. Please refer to the new report for updated projections. |
@bodiyang Is this still a work in progress? |
@jdebacker I just tried to merge new updates from master into this PR and saw some new error. Will solve this soon. |
@bodiyang, When this PR passes all the tests, you can convert it from a draft to ready-to-review. |
@jdebacker This PR is ready for review |
@bodiyang These changes are small, but make sense to me. And I confirmed all tests, including those using the PUF, do pass for me locally. Therefore, I am going to merge this PR. One note: I still find the PUF file to be off the mark for estimating certain reforms. E.g., I have used Tax-Calculator to estimate the 10 year cost of TCJA extension using
For comparison, the Budget Lab at Yale scores this at -$2,816B (under conventional scoring -- so not a static estimate as those above) -- and JCT/CBO are similar to that. If one applies similar behavior, I think he TMD score from Tax-Calculator would be very close to those from Yale or JCT. That is to say, while this PR makes appropriate updates the the files used for the PUF and CPS datasets, these two datasets are still missing some key targets. |
Add changes that should have been part of PR #2831
This PR is to update Tax-Calculator for the June 2024 CBO baseline update.
This is the next step to the Tax-Data CBO update, which updates Tax-Calculator with the new files of PUF weights, ratios.