Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBO June 2024 update #2831

Merged
merged 22 commits into from
Dec 12, 2024
Merged

CBO June 2024 update #2831

merged 22 commits into from
Dec 12, 2024

Conversation

bodiyang
Copy link
Contributor

@bodiyang bodiyang commented Nov 4, 2024

This PR is to update Tax-Calculator for the June 2024 CBO baseline update.

This is the next step to the Tax-Data CBO update, which updates Tax-Calculator with the new files of PUF weights, ratios.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (23b3b5e) to head (d30b758).
Report is 33 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2831   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2619     2619           
=======================================
  Hits         2604     2604           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@martinholmer martinholmer marked this pull request as draft November 4, 2024 20:53
@martinholmer
Copy link
Collaborator

@bodiyang, I have two questions to start with:

(1) If you are updating using the new CBO 2024+ projections, why are the historical results as far back as 2021 changing? Why are you revising HISTORY?

(2) If you are updating using the new CBO 2024+ projections, why are the 2024+ contents
of the growfactors.csv file not changing?

@bodiyang
Copy link
Contributor Author

bodiyang commented Nov 5, 2024

@martinholmer

For (1): It is because CBO themselves revised the baseline value for the previous years in June 2024 publication.

Same can be seen in Tax-data's CBO_baseline.csv. This file shows the baseline difference between June 2024 publication and Feb 2024 publication.

@bodiyang
Copy link
Contributor Author

bodiyang commented Nov 5, 2024

@martinholmer

I'm also having recheck on growth factors now. Will send updates later

@martinholmer
Copy link
Collaborator

martinholmer commented Nov 5, 2024

@bodiyang said in PR #2831:

For (1): It is because CBO themselves revised the baseline value for the previous years in June 2024 publication.

OK. What is the answer to my question (2)?

@bodiyang
Copy link
Contributor Author

bodiyang commented Nov 5, 2024

@martinholmer @jdebacker

There has been a new update from BLS for CPI in September, which will affect the growth factor, baseline, ... files. I will make another update in Tax-Data and incorporate the change in this Tax-Calculator PR.

@martinholmer
Copy link
Collaborator

@bodiyang said:

There has been a new update from BLS for CPI in September, which will affect the growth factor

I don't understand. Are you saying CBO did not change its economic projections in the June report? Why are you planning to change only the CPI projection?

Also, if you change the CPI projection in growfactors.csv, be sure to do this as described in taxdata issue #444.

@bodiyang
Copy link
Contributor Author

bodiyang commented Nov 5, 2024

I don't understand. Are you saying CBO did not change its economic projections in the June report? Why are you planning to change only the CPI projection?

CBO changed its economic projections in the June report and it has already been reflected in this June report.

The "CBO update process" in Tax-Data actually also includes the updates from BLS. details can be found at updatecbo.py

I completed the CBO update process in Tax-Data in August, but I just noticed that BLS has made an update in CPI (which will affect the CPIM in CBO_baseline.csv) in September. So I decide to make an update for this.

And thanks for bringing up the taxdata issue #444 , I will do the update from there.

@martinholmer
Copy link
Collaborator

@bodiyang said:

CBO changed its economic projections in the June report and it has already been reflected in this June report.

This sentence makes no sense to me. When I look at taxdata growfactors.csv it has not changed in eight months even though CBO has new June economic projections. Why are you not using the new June CBO economic projections?

@bodiyang
Copy link
Contributor Author

bodiyang commented Nov 5, 2024

@bodiyang said:

CBO changed its economic projections in the June report and it has already been reflected in this June report.

This sentence makes no sense to me. When I look at taxdata growfactors.csv it has not changed in eight months even though CBO has new June economic projections. Why are you not using the new June CBO economic projections?

  1. Yes, I am using the new CBO June 2024 update
  2. I am currently working on another update in Tax-Data, which will reflect CBO June 2024 update as well as recent BLS update ~ This update will show change in growth factor. I haven't put it up on github yet, but already get it locally.
  3. Last Tax-Data PR: This PR reflect the CBO June 2024, resulting in change of weight files, ratio files ... But it does not result in the change in growth factors. ~~ I didn't conduct a thorough check the reason why growth factor changed there (Maybe the change of baseline is not large enough / or Maybe there is a mistake). However, the update process follow the standard procedure of CBO update, and the produced files passed all tests in Tax-Data & Tax-Calculator. And the projection result looks good, as in this new report.

In a conclusion, I will make another update in Tax-Data with the new changes, including growth factors, soon. Would make sense to wait a lit bit as I'm finalizing it.

@bodiyang
Copy link
Contributor Author

@jdebacker @martinholmer This PR is ready for review.

Please refer to the new report for updated projections.

@jdebacker
Copy link
Member

@bodiyang Is this still a work in progress?

@bodiyang bodiyang marked this pull request as ready for review December 3, 2024 13:45
@bodiyang
Copy link
Contributor Author

bodiyang commented Dec 3, 2024

@jdebacker I just tried to merge new updates from master into this PR and saw some new error. Will solve this soon.

@martinholmer martinholmer marked this pull request as draft December 3, 2024 14:45
@martinholmer
Copy link
Collaborator

@bodiyang, When this PR passes all the tests, you can convert it from a draft to ready-to-review.

@bodiyang
Copy link
Contributor Author

bodiyang commented Dec 9, 2024

@jdebacker This PR is ready for review

@bodiyang bodiyang marked this pull request as ready for review December 9, 2024 14:22
@jdebacker
Copy link
Member

@bodiyang These changes are small, but make sense to me. And I confirmed all tests, including those using the PUF, do pass for me locally. Therefore, I am going to merge this PR.

One note: I still find the PUF file to be off the mark for estimating certain reforms. E.g., I have used Tax-Calculator to estimate the 10 year cost of TCJA extension using reforms/ext.json. I have found:

  • With taxcalc before the changes proposed here: -$2,387B
  • With changes in this PR: -$2,376B
  • With the TMD file: -$3,211B

For comparison, the Budget Lab at Yale scores this at -$2,816B (under conventional scoring -- so not a static estimate as those above) -- and JCT/CBO are similar to that. If one applies similar behavior, I think he TMD score from Tax-Calculator would be very close to those from Yale or JCT.

That is to say, while this PR makes appropriate updates the the files used for the PUF and CPS datasets, these two datasets are still missing some key targets.

@jdebacker jdebacker merged commit 1cad505 into PSLmodels:master Dec 12, 2024
9 checks passed
@bodiyang bodiyang deleted the CBO_June_24 branch December 12, 2024 16:06
@martinholmer martinholmer removed the WIP label Dec 15, 2024
martinholmer added a commit that referenced this pull request Dec 15, 2024
Add changes that should have been part of PR #2831
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants