Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include setax and ptax_amc in income tax rather than in payroll tax #2844

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

martinholmer
Copy link
Collaborator

@martinholmer martinholmer commented Nov 27, 2024

Fixes #2843 bug by including both the self-employment tax (setax) and the additional Medicare tax (ptax_amc) in othertaxes, and therefore, in the iitax variable (rather than including them both in the payrolltax variable).

Note that the potentially-confusing variable name for the additional Medicare tax (ptax_amc) has been retained in order to avoid breaking backwards compatibility.

Most of the test changes in this PR involve changing expected iitax and payrolltax values to correspond to the values generated by the new version of Tax-Calculator in this PR. However, test_itax_compare in the taxcalc/tests/test_compare.py module, is different in this respect. Its expected values are published IRS/SOI income tax statistics for 2015. Before the changes in this PR, the aggregate iitax generated by the model using the puf.csv input data was 1406.456 billion dollars, which was about 3.5 percent below the IRS/SOI amount of 1457.891 billion dollars. Using the changes in this PR, the model now generates 1462.385 billion dollars, which is about 0.3% above the IRS/SOI amount of 1457.891 billion dollars.

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.42%. Comparing base (404ac22) to head (c15b063).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2844   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          13       13           
  Lines        2619     2619           
=======================================
  Hits         2604     2604           
  Misses         15       15           
Flag Coverage Δ
unittests 99.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
taxcalc/__init__.py 100.00% <100.00%> (ø)

@martinholmer martinholmer merged commit d2b77ad into PSLmodels:master Nov 29, 2024
9 checks passed
@martinholmer martinholmer deleted the fix-2843-bug branch November 29, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect classification of self-employment tax and additional Medicare tax
1 participant