Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect use of GrowFactors() in Policy and Parameters classes #2852

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Remove incorrect use of GrowFactors() in Policy and Parameters classes #2852

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
fca9817
Remove setting self._gfactors in Parameters.adjust_with_indexing
martinholmer Dec 14, 2024
dd98ef0
Remove setting self._gfactors in Policy.set_rates
martinholmer Dec 15, 2024
051727d
Fix reform_documentation logic
martinholmer Dec 15, 2024
46f95a4
Use new reform_documentation arguments in test
martinholmer Dec 15, 2024
67f6323
Use new reform_documentation arguments in TaxCalcIO logic
martinholmer Dec 15, 2024
138a4e1
Fix test_parameters to use new Parameters logic
martinholmer Dec 15, 2024
7f6958e
Update version to 4.3.4a
martinholmer Dec 15, 2024
83d0d39
Fix typo
martinholmer Dec 15, 2024
5b00912
No coverage of obsolete code now that _offset is always zero in p_c_l…
martinholmer Dec 15, 2024
b60499e
Fix typo in policy.py module
martinholmer Dec 15, 2024
8cf5ba5
Simplify Policy.set_rates logic
martinholmer Dec 15, 2024
f71b8b1
Merge in recent changes on master branch
martinholmer Dec 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use new reform_documentation arguments in TaxCalcIO logic
  • Loading branch information
@martinholmer
martinholmer committed Dec 15, 2024
commit 67f63236322cdf266dc6f722039668cb09a06051
11 changes: 8 additions & 3 deletions taxcalc/taxcalcio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def __init__(self, input_data, tax_year, baseline, reform, assump,
outdir=None):
# pylint: disable=too-many-arguments,too-many-locals
# pylint: disable=too-many-branches,too-many-statements
self.gf_reform = None
self.errmsg = ''
# check name and existence of INPUT file
inp = 'x'
Expand Down Expand Up @@ -288,6 +289,7 @@ def init(self, input_data, tax_year, baseline, reform, assump,
gfactors_ref = GrowFactors()
gdiff_baseline.apply_to(gfactors_ref)
gdiff_response.apply_to(gfactors_ref)
self.gf_reform = copy.deepcopy(gfactors_ref)
# create Policy objects:
# ... the baseline Policy object
base = Policy(gfactors=gfactors_base)
Expand Down Expand Up @@ -571,10 +573,13 @@ def write_doc_file(self):
Write reform documentation to text file.
"""
if len(self.policy_dicts) <= 1:
doc = Calculator.reform_documentation(self.param_dict)
doc = Calculator.reform_documentation(
self.param_dict, self.gf_reform
)
else:
doc = Calculator.reform_documentation(self.param_dict,
self.policy_dicts[1:])
doc = Calculator.reform_documentation(
self.param_dict, self.gf_reform, self.policy_dicts[1:]
)
doc_fname = self._output_filename.replace('.csv', '-doc.text')
with open(doc_fname, 'w', encoding='utf-8') as dfile:
dfile.write(doc)
Expand Down