forked from anitaNeutrino/libAntarcticaRoot
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMakeLists #2
Open
unmovingcastle
wants to merge
33
commits into
master
Choose a base branch
from
updateCMake
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+267
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it probably needs to be updated somehow
-g -Wall -Wextra and such are already PUBLIC in RootFftwWrapper and so they propagate here
as per the original cmakelists
This is done through find_dependency(...) in the config file. This is needed for downstream projects to find RootFftwWrapper via this package.
no need to "generate" the config file. https://blog.vito.nyc/posts/cmake-pkg/
not used by this repo either
These flags were originally intended to be used in RootFftwWrapper (see its Master branch) but now if I use them in RootFftwWrapper, peuoSim seg faults. Also, if I put these things in AntarcticaRoot, everything seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to go with pueoBuilder's CleanUp branch
and libRootFftwWrapper's updateCMake branch
and NiceMC's updateCMake branch
and pueoSim's updateCMake branch
and pueo-data's updateCMake branch
and pueoEvent's updateCMake branch
THESE PRs NEED TO BE MERGED SIMULTANEOUSLY
general
target_*()
commands whenever possible to avoid adding things globally.find_package()
and obtain thePUBLIC
compiler flags/definitions, header files, and library automatically when they link againstAntarcticaRoot
; resources:modern way to package things
find_package(CONFIG)
mode and linking throughNamespace::target
wherever possible; e.g.ZLIB::ZLIB
(although not sure if zlib is actually needed).find_package(FFTW)
: not used byAntarcticaRoot
(although still linking against fftw libraries through upstreamRootFftwWrapper
because it is set toPUBLIC
there)find_package()
can correctly identifyAntarcticaRoot
's include path automatically;AntarcticaRoot
's header files now grouped together in a single directory in the install treecompiler flags and definitions
USE_FFT_TOOLS
removed (not used by any repo)USE_GEOGRAPHIC_LIB
compiled and is set toPRIVATE
at the moment (because downstream projects don't seem to use these compiler definitions)USE_HEALPIX
seems broken although set toPUBLIC
(NiceMC
could need this). That said,USE_HEALPIX
doesn't seem to be utilized byAntarcticaRoot
's source code-g
and-O2
removed since these are determined by CMake build types-Wall
and-Wextra
inDebug
mode; resources:Modern CMake generator expression
FORCE_OLD_GPP_ABI
; the associated compiler flag should come from upstreamRootFftwWrapper
(ie. if upstream is built with this option, the flag will propagate)-march=native
now comes from upstreamRootFftwWrapper
'sNATIVE_ARCH
option (ie. if upstream is built with this option, the flag will propagate)CERN ROOT
#include <>
directives in the source files to determine theROOT::<targets>
to link against (instead of linking against the entire ROOT library${ROOT_LIBRARIES}
). See CERN ROOT's CMake project example. The checklist is stored incmake/rootLibList.txt
.CERN ROOT Forum
Modern CMake CERN ROOT section
ROOT::<targets>
PRIVATE
ly to avoid redundant linking downstream.