Update CMakeLists #2
Open
+267
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 26 commits
December 19, 2024 05:54
it probably needs to be updated somehow
-g -Wall -Wextra and such are already PUBLIC in RootFftwWrapper and so they propagate here
as per the original cmakelists
This is done through find_dependency(...) in the config file. This is needed for downstream projects to find RootFftwWrapper via this package.
no need to "generate" the config file. https://blog.vito.nyc/posts/cmake-pkg/
added 6 commits
December 30, 2024 21:52
not used by this repo either
These flags were originally intended to be used in RootFftwWrapper (see its Master branch) but now if I use them in RootFftwWrapper, peuoSim seg faults. Also, if I put these things in AntarcticaRoot, everything seems fine.
cozzyd
approved these changes
Feb 27, 2025
| find_package(ROOT CONFIG REQUIRED COMPONENTS HistPainter Physics Ged) | ||
| find_package(ZLIB REQUIRED) # TODO: figure out if zlib is required | ||
|
|
||
| set_target_properties(${PROJECT_NAME} PROPERTIES CXX_EXTENSIONS OFF) # turns -std=gnu++17 -> -std=c++17 |
There was a problem hiding this comment.
what's the advantage of c++17 over gnu++17? I wouldn't be surprised if GNU extensions are used somewhere (though I guess in that case it wouldn't have compiled would it...)
| if(USE_HEALPIX) | ||
| list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") | ||
| find_package(HealPix REQUIRED) | ||
| # TODO: this preprocessor definition doesn't seem to be implemented in the source code? |
There was a problem hiding this comment.
I don't think HEALPIX functionality was ported from ANITA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PR to go with pueoBuilder's CleanUp branch
and libRootFftwWrapper's updateCMake branch
and NiceMC's updateCMake branch
and pueoSim's updateCMake branch
and pueo-data's updateCMake branch
and pueoEvent's updateCMake branch
THESE PRs NEED TO BE MERGED SIMULTANEOUSLY
general
target_*()commands whenever possible to avoid adding things globally.find_package()and obtain thePUBLICcompiler flags/definitions, header files, and library automatically when they link againstAntarcticaRoot; resources:modern way to package things
find_package(CONFIG)mode and linking throughNamespace::targetwherever possible; e.g.ZLIB::ZLIB(although not sure if zlib is actually needed).find_package(FFTW): not used byAntarcticaRoot(although still linking against fftw libraries through upstreamRootFftwWrapperbecause it is set toPUBLICthere)find_package()can correctly identifyAntarcticaRoot's include path automatically;AntarcticaRoot's header files now grouped together in a single directory in the install treecompiler flags and definitions
USE_FFT_TOOLSremoved (not used by any repo)USE_GEOGRAPHIC_LIBcompiled and is set toPRIVATEat the moment (because downstream projects don't seem to use these compiler definitions)USE_HEALPIXseems broken although set toPUBLIC(NiceMCcould need this). That said,USE_HEALPIXdoesn't seem to be utilized byAntarcticaRoot's source code-gand-O2removed since these are determined by CMake build types-Walland-WextrainDebugmode; resources:Modern CMake generator expression
FORCE_OLD_GPP_ABI; the associated compiler flag should come from upstreamRootFftwWrapper(ie. if upstream is built with this option, the flag will propagate)-march=nativenow comes from upstreamRootFftwWrapper'sNATIVE_ARCHoption (ie. if upstream is built with this option, the flag will propagate)CERN ROOT
#include <>directives in the source files to determine theROOT::<targets>to link against (instead of linking against the entire ROOT library${ROOT_LIBRARIES}). See CERN ROOT's CMake project example. The checklist is stored incmake/rootLibList.txt.CERN ROOT Forum
Modern CMake CERN ROOT section
ROOT::<targets>PRIVATEly to avoid redundant linking downstream.