Navio: Add support for SPI-connected GPS #5
Conversation
| @@ -108,10 +108,12 @@ GPSDriverUBX::configure(unsigned &baudrate, OutputMode output_mode) | |||
| { | |||
| _configured = false; | |||
| _output_mode = output_mode; | |||
| #if !defined(__PX4_POSIX_RPI) | |||
There was a problem hiding this comment.
It would be good if you could change this to an interface flag instead configure(enum interface, unsigned baud, output mode). Then the interface setting controls wether or not the baud rate is applied
There was a problem hiding this comment.
I think it would be better if we add the interface information to the GPSDriverUBX constructor since the interface information is static?
There was a problem hiding this comment.
Makes sense, yes. That's better than my original proposal.
| @@ -413,6 +436,18 @@ GPSDriverUBX::receive(unsigned timeout) | |||
| handled |= parseChar(buf[i]); | |||
| //UBX_DEBUG("parsed %d: 0x%x", i, buf[i]); | |||
| } | |||
|
|
|||
| #if defined(__PX4_POSIX_RPI) | |||
There was a problem hiding this comment.
Why is this RPI specific? Isn't this rather SPI interface specific?
There was a problem hiding this comment.
So should use if (_interface == GPSHelper::Interface::SPI) instead.
There was a problem hiding this comment.
@mayanez Have you seen this bit of feedback?
|
cleaned up & applied |
This adds support for a U-blox GPS device on SPI bus. This needs another PR for the Firmware.