Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CodeStyle][Typos][A-[11-19]] Fix typo(addtional、addess、adjancent、admissable、afer、Ags、aggragate、alis、algorithem、alogrithm) #69472

Merged
merged 3 commits into from
Nov 19, 2024
Merged

[CodeStyle][Typos][A-[11-19]] Fix typo(addtional、addess、adjancent、admissable、afer、Ags、aggragate、alis、algorithem、alogrithm) #69472

merged 3 commits into from
Nov 19, 2024
+14 −24

Conversation

WAYKEN-TSE
Copy link
Contributor

@WAYKEN-TSE WAYKEN-TSE commented Nov 18, 2024 •
edited
Loading

PR Category

User Experience

PR Types

Devs

Description

修复：

  • addtional
  • addess
  • adjancent
  • admissable
  • afer
  • Ags
  • aggragate
  • alis
  • algorithem
  • alogrithm

@paddle-bot Paddle-bot
Copy link

paddle-bot bot commented Nov 18, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@CLAassistant
Copy link

CLAassistant commented Nov 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@paddle-bot paddle-bot bot added the contributor External developers label Nov 18, 2024
@SigureMo SigureMo mentioned this pull request Nov 18, 2024
Open
@SigureMo SigureMo requested a review from Copilot November 18, 2024 11:15
Copilot
Copilot AI reviewed Nov 18, 2024
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 10 changed files in this pull request and generated no suggestions.

Files not reviewed (9)
  • paddle/cinn/backends/codegen_gpu_dev.cc: Language not supported
  • paddle/cinn/poly/stage.cc: Language not supported
  • paddle/fluid/framework/fleet/heter_ps/graph_gpu_ps_table_inl.cu: Language not supported
  • paddle/fluid/framework/ir/graph_helper.cc: Language not supported
  • paddle/fluid/pir/dialect/operator/interface/infer_symbolic_shape/unary_infer_sym.cc: Language not supported
  • paddle/fluid/pir/transforms/general/transfer_layout_pass.cc: Language not supported
  • paddle/phi/backends/onednn/onednn_context.cc: Language not supported
  • paddle/phi/kernels/gpu/rms_norm_kernel.cu: Language not supported
  • paddle/phi/kernels/gpudnn/conv_cudnn_v7.h: Language not supported
@WAYKEN-TSE WAYKEN-TSE closed this Nov 18, 2024
@WAYKEN-TSE WAYKEN-TSE reopened this Nov 18, 2024
@SigureMo
Copy link
Member

  • 按照模板写清 PR 描述
  • 签署 CLA

@SigureMo
Copy link
Member

完成的需要将相关单词从配置中删除

@MrXnneHang
Copy link
Contributor

details里，右上角有一个重构建，可以重新运行CI。

@MrXnneHang
Copy link
Contributor

@WAYKEN-TSE
Copy link
Contributor Author

  • 按照模板写清 PR 描述
  • 签署 CLA

请问我应该如何重写PR呢，我需要重新将前面所有步骤（改词等）再做一遍吗

@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 19, 2024 •
edited
Loading

@WAYKEN-TSE
右上角有三个点，可以edit
PR,CI,Git相关问题可以提到我引用的那个Issue里，我会统计成FAQ
image
image

@WAYKEN-TSE WAYKEN-TSE changed the title [CodeStyle][Typos][A-[11-19]] Fix typo(addtionaladdessadjancentadmissableaferAgsaggragatealisalgorithemalogrithm) [CodeStyle][Typos][A-[11-19]] Fix typo(addtional、addess、adjancent、admissable、afer、Ags、aggragate、alis、algorithem、alogrithm) Nov 19, 2024
@WAYKEN-TSE
Copy link
Contributor Author

完成的需要将相关单词从配置中删除

配置是指_typos.toml文件吗

@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 19, 2024 •
edited
Loading

对,直接删了

我的意思是()内可选写，也可以不写。你连()都写了..,

这样也行

@WAYKEN-TSE
Copy link
Contributor Author

@WAYKEN-TSE 右上角有三个点，可以edit PR,CI,Git相关问题可以提到我引用的那个Issue里，我会统计成FAQ image image

你好，我的description修改完成了，但是checkPRTemplate一直构建不了

@WAYKEN-TSE
Copy link
Contributor Author

对,直接删了

我的意思是()内可选写，也可以不写。你连()都写了..,

这样也行

但是我这里已经有十个文件了，这个_typos.toml需要怎么重新提交呢

@MrXnneHang
Copy link
Contributor

MrXnneHang commented Nov 19, 2024 •
edited
Loading

没事，直接提交。

提交新的commit也会重新运行所有CI.

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Nov 19, 2024
@WAYKEN-TSE
Copy link
Contributor Author

没事，直接提交。

提交新的commit也会重新运行所有CI.

请问PR-CI-Kunlun-R200测试出错了，应该怎么解决呢

@luotao1
Copy link
Contributor

luotao1 commented Nov 19, 2024

请问PR-CI-Kunlun-R200测试出错了，应该怎么解决呢

非 required CI 可以先不考虑

@WAYKEN-TSE
Copy link
Contributor Author

PR-CI-Model-benchmark

那请问PR-CI-Model-benchmark出错了该怎么解决呢

SigureMo
SigureMo approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMeow 🐾

@SigureMo
Copy link
Member

那请问PR-CI-Model-benchmark出错了该怎么解决呢

这种看起来与你无关的，重新构建即可

@SigureMo SigureMo merged commit bb449ff into PaddlePaddle:develop Nov 19, 2024
27 of 28 checks passed
@WAYKEN-TSE WAYKEN-TSE mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Copilot left review comments

@SigureMo SigureMo SigureMo approved these changes

Assignees

@luotao1 luotao1

@SigureMo SigureMo

Labels
contributor External developers HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@WAYKEN-TSE @CLAassistant @SigureMo @MrXnneHang @luotao1